From f686978f5cf82eda119826c83e84f77b74346e75 Mon Sep 17 00:00:00 2001
From: Drake Arconis <drake@alchemyviewer.org>
Date: Tue, 27 Jun 2017 16:35:57 -0400
Subject: [PATCH] More std::function
---
indra/llui/lluictrl.cpp | 8 ++--
indra/llui/lluictrl.h | 4 +-
indra/newview/llaisapi.h | 2 +-
indra/newview/llcompilequeue.h | 2 +-
indra/newview/llfloaterexperiences.cpp | 2 +-
indra/newview/llfloaterexperiences.h | 4 +-
indra/newview/llnotificationlistitem.h | 2 +-
indra/newview/lltexturectrl.cpp | 56 +++++++++++++-------------
indra/newview/lltexturectrl.h | 8 ++--
indra/newview/lltranslate.cpp | 6 +--
indra/newview/lltranslate.h | 6 +--
indra/newview/llviewerassetupload.h | 4 +-
indra/newview/llvoicevivox.h | 2 +-
13 files changed, 53 insertions(+), 53 deletions(-)
diff --git a/indra/llui/lluictrl.cpp b/indra/llui/lluictrl.cpp
index f6c3fe4889..61891c9abf 100644
--- a/indra/llui/lluictrl.cpp
+++ b/indra/llui/lluictrl.cpp
@@ -942,16 +942,16 @@ bool LLUICtrl::findHelpTopic(std::string& help_topic_out)
}
// *TODO: Deprecate; for backwards compatability only:
-boost::signals2::connection LLUICtrl::setCommitCallback( boost::function<void (LLUICtrl*,void*)> cb, void* data)
+boost::signals2::connection LLUICtrl::setCommitCallback( std::function<void (LLUICtrl*,void*)> cb, void* data)
{
- return setCommitCallback( boost::bind(cb, _1, data));
+ return setCommitCallback( std::bind(cb, std::placeholders::_1, data));
}
-boost::signals2::connection LLUICtrl::setValidateBeforeCommit( boost::function<bool (const LLSD& data)> cb )
+boost::signals2::connection LLUICtrl::setValidateBeforeCommit( std::function<bool (const LLSD& data)> cb )
{
if (!mValidateSignal) mValidateSignal = new enable_signal_t();
claimMem(mValidateSignal);
- return mValidateSignal->connect(boost::bind(cb, _2));
+ return mValidateSignal->connect(std::bind(cb, std::placeholders::_2));
}
// virtual
diff --git a/indra/llui/lluictrl.h b/indra/llui/lluictrl.h
index 75041219f2..f08a8a255d 100644
--- a/indra/llui/lluictrl.h
+++ b/indra/llui/lluictrl.h
@@ -249,8 +249,8 @@ public:
boost::signals2::connection setDoubleClickCallback( const mouse_signal_t::slot_type& cb );
// *TODO: Deprecate; for backwards compatability only:
- boost::signals2::connection setCommitCallback( boost::function<void (LLUICtrl*,void*)> cb, void* data);
- boost::signals2::connection setValidateBeforeCommit( boost::function<bool (const LLSD& data)> cb );
+ boost::signals2::connection setCommitCallback( std::function<void (LLUICtrl*,void*)> cb, void* data);
+ boost::signals2::connection setValidateBeforeCommit( std::function<bool (const LLSD& data)> cb );
LLUICtrl* findRootMostFocusRoot();
diff --git a/indra/newview/llaisapi.h b/indra/newview/llaisapi.h
index 685c9596d5..755ecac253 100644
--- a/indra/newview/llaisapi.h
+++ b/indra/newview/llaisapi.h
@@ -65,7 +65,7 @@ private:
static const std::string INVENTORY_CAP_NAME;
static const std::string LIBRARY_CAP_NAME;
- typedef boost::function < LLSD (LLCoreHttpUtil::HttpCoroutineAdapter::ptr_t, LLCore::HttpRequest::ptr_t,
+ typedef std::function < LLSD (LLCoreHttpUtil::HttpCoroutineAdapter::ptr_t, LLCore::HttpRequest::ptr_t,
const std::string, LLSD, LLCore::HttpOptions::ptr_t, LLCore::HttpHeaders::ptr_t) > invokationFn_t;
static void EnqueueAISCommand(const std::string &procName, LLCoprocedureManager::CoProcedure_t proc);
diff --git a/indra/newview/llcompilequeue.h b/indra/newview/llcompilequeue.h
index 15587f6748..c9cd17ec34 100644
--- a/indra/newview/llcompilequeue.h
+++ b/indra/newview/llcompilequeue.h
@@ -102,7 +102,7 @@ protected:
std::string mStartString;
bool mMono;
- typedef boost::function<bool(const LLPointer<LLViewerObject> &, LLInventoryObject*, LLEventPump &)> fnQueueAction_t;
+ typedef std::function<bool(const LLPointer<LLViewerObject> &, LLInventoryObject*, LLEventPump &)> fnQueueAction_t;
static void objectScriptProcessingQueueCoro(std::string action, LLHandle<LLFloaterScriptQueue> hfloater, object_data_list_t objectList, fnQueueAction_t func);
};
diff --git a/indra/newview/llfloaterexperiences.cpp b/indra/newview/llfloaterexperiences.cpp
index 64197d07b2..7041fd82b4 100644
--- a/indra/newview/llfloaterexperiences.cpp
+++ b/indra/newview/llfloaterexperiences.cpp
@@ -408,7 +408,7 @@ void LLFloaterExperiences::retrieveExperienceListCoro(std::string url,
{
const LLSD& ids = result[it->first];
tab->setExperienceList(ids);
- if (!cback.empty())
+ if (cback != nullptr)
{
cback(tab, result);
}
diff --git a/indra/newview/llfloaterexperiences.h b/indra/newview/llfloaterexperiences.h
index de37974b8e..b3ed036be3 100644
--- a/indra/newview/llfloaterexperiences.h
+++ b/indra/newview/llfloaterexperiences.h
@@ -43,7 +43,7 @@ public:
static LLFloaterExperiences* findInstance();
protected:
typedef std::map<std::string, std::string> NameMap_t;
- typedef boost::function<void(LLPanelExperiences*, const LLSD&)> Callback_t;
+ typedef std::function<void(LLPanelExperiences*, const LLSD&)> Callback_t;
void clearFromRecent(const LLSD& ids);
void resizeToTabs();
@@ -65,7 +65,7 @@ protected:
const std::string &errorNotify, Callback_t cback);
private:
- typedef boost::function < LLSD(LLCoreHttpUtil::HttpCoroutineAdapter::ptr_t, LLCore::HttpRequest::ptr_t,
+ typedef std::function < LLSD(LLCoreHttpUtil::HttpCoroutineAdapter::ptr_t, LLCore::HttpRequest::ptr_t,
const std::string, LLCore::HttpOptions::ptr_t, LLCore::HttpHeaders::ptr_t) > invokationFn_t;
static void retrieveExperienceListCoro(std::string url, LLHandle<LLFloaterExperiences> hparent,
diff --git a/indra/newview/llnotificationlistitem.h b/indra/newview/llnotificationlistitem.h
index 09492dcd93..f9c0e91b2e 100644
--- a/indra/newview/llnotificationlistitem.h
+++ b/indra/newview/llnotificationlistitem.h
@@ -83,7 +83,7 @@ public:
void onMouseLeave(S32 x, S32 y, MASK mask) override;
//callbacks
- typedef boost::function<void (LLNotificationListItem* item)> item_callback_t;
+ typedef std::function<void (LLNotificationListItem* item)> item_callback_t;
typedef boost::signals2::signal<void (LLNotificationListItem* item)> item_signal_t;
item_signal_t mOnItemClose;
item_signal_t mOnItemClick;
diff --git a/indra/newview/lltexturectrl.cpp b/indra/newview/lltexturectrl.cpp
index f34aa3f117..804687fa79 100644
--- a/indra/newview/lltexturectrl.cpp
+++ b/indra/newview/lltexturectrl.cpp
@@ -107,10 +107,10 @@ LLFloaterTexturePicker::LLFloaterTexturePicker(
mTentative(tentative),
mAllowNoTexture(allow_no_texture),
mLabel(label),
- mTentativeLabel(NULL),
- mResolutionLabel(NULL),
+ mTentativeLabel(nullptr),
+ mResolutionLabel(nullptr),
mActive( TRUE ),
- mFilterEdit(NULL),
+ mFilterEdit(nullptr),
mImmediateFilterPermMask(immediate_filter_perm_mask),
mDnDFilterPermMask(dnd_filter_perm_mask),
mNonImmediateFilterPermMask(non_immediate_filter_perm_mask),
@@ -119,10 +119,10 @@ LLFloaterTexturePicker::LLFloaterTexturePicker(
mCanApply(true),
mCanPreview(true),
mPreviewSettingChanged(false),
- mOnFloaterCommitCallback(NULL),
- mOnFloaterCloseCallback(NULL),
- mSetImageAssetIDCallback(NULL),
- mOnUpdateImageStatsCallback(NULL)
+ mOnFloaterCommitCallback(nullptr),
+ mOnFloaterCloseCallback(nullptr),
+ mSetImageAssetIDCallback(nullptr),
+ mOnUpdateImageStatsCallback(nullptr)
{
buildFromFile("floater_texture_ctrl.xml");
mCanApplyImmediately = can_apply_immediately;
@@ -199,7 +199,7 @@ void LLFloaterTexturePicker::updateImageStats()
{
std::string formatted_dims = llformat("%d x %d", mTexturep->getFullWidth(),mTexturep->getFullHeight());
mResolutionLabel->setTextArg("[DIMENSIONS]", formatted_dims);
- if (mOnUpdateImageStatsCallback)
+ if (mOnUpdateImageStatsCallback != nullptr)
{
mOnUpdateImageStatsCallback(mTexturep);
}
@@ -309,7 +309,7 @@ BOOL LLFloaterTexturePicker::handleKeyHere(KEY key, MASK mask)
void LLFloaterTexturePicker::onClose(bool app_quitting)
{
- if (mOwner && mOnFloaterCloseCallback)
+ if (mOwner && mOnFloaterCloseCallback != nullptr)
{
mOnFloaterCloseCallback();
}
@@ -475,7 +475,7 @@ void LLFloaterTexturePicker::draw()
//BOOL allow_copy = FALSE;
if( mOwner )
{
- mTexturep = NULL;
+ mTexturep = nullptr;
if(mImageAssetID.notNull())
{
mTexturep = LLViewerTextureManager::getFetchedTexture(mImageAssetID);
@@ -616,7 +616,7 @@ PermissionMask LLFloaterTexturePicker::getFilterPermMask()
void LLFloaterTexturePicker::commitIfImmediateSet()
{
- if (!mNoCopyTextureSelected && mOnFloaterCommitCallback && mCanApply)
+ if (!mNoCopyTextureSelected && mOnFloaterCommitCallback != nullptr && mCanApply)
{
mOnFloaterCommitCallback(LLTextureCtrl::TEXTURE_CHANGE, LLUUID::null);
}
@@ -624,7 +624,7 @@ void LLFloaterTexturePicker::commitIfImmediateSet()
void LLFloaterTexturePicker::commitCancel()
{
- if (!mNoCopyTextureSelected && mOnFloaterCommitCallback && mCanApply)
+ if (!mNoCopyTextureSelected && mOnFloaterCommitCallback != nullptr && mCanApply)
{
mOnFloaterCommitCallback(LLTextureCtrl::TEXTURE_CANCEL, LLUUID::null);
}
@@ -688,7 +688,7 @@ void LLFloaterTexturePicker::onBtnCancel(void* userdata)
{
LLFloaterTexturePicker* self = (LLFloaterTexturePicker*) userdata;
self->setImageID( self->mOriginalImageAssetID );
- if (self->mOnFloaterCommitCallback)
+ if (self->mOnFloaterCommitCallback != nullptr)
{
self->mOnFloaterCommitCallback(LLTextureCtrl::TEXTURE_CANCEL, LLUUID::null);
}
@@ -709,7 +709,7 @@ void LLFloaterTexturePicker::onBtnSelect(void* userdata)
local_id = LLLocalBitmapMgr::getWorldID(temp_id);
}
}
- if (self->mOnFloaterCommitCallback)
+ if (self->mOnFloaterCommitCallback != nullptr)
{
self->mOnFloaterCommitCallback(LLTextureCtrl::TEXTURE_SELECT, local_id);
}
@@ -751,7 +751,7 @@ void LLFloaterTexturePicker::onSelectionChange(const std::deque<LLFolderViewItem
mNoCopyTextureSelected = FALSE;
if (itemp)
{
- if (mTextureSelectedCallback)
+ if (mTextureSelectedCallback != nullptr)
{
mTextureSelectedCallback(itemp);
}
@@ -876,14 +876,14 @@ void LLFloaterTexturePicker::onLocalScrollCommit()
{
LLUUID tracking_id = LLUUID(mLocalScrollCtrl->getSelectedItemLabel(LOCAL_TRACKING_ID_COLUMN));
LLUUID inworld_id = LLLocalBitmapMgr::getWorldID(tracking_id);
- if (mSetImageAssetIDCallback)
+ if (mSetImageAssetIDCallback != nullptr)
{
mSetImageAssetIDCallback(inworld_id);
}
if (childGetValue("apply_immediate_check").asBoolean())
{
- if (mOnFloaterCommitCallback)
+ if (mOnFloaterCommitCallback != nullptr)
{
mOnFloaterCommitCallback(LLTextureCtrl::TEXTURE_CHANGE, inworld_id);
}
@@ -1207,11 +1207,11 @@ void LLTextureCtrl::showPicker(BOOL take_focus)
LLFloaterTexturePicker* texture_floaterp = dynamic_cast<LLFloaterTexturePicker*>(floaterp);
if (texture_floaterp)
{
- if (mOnTextureSelectedCallback)
+ if (mOnTextureSelectedCallback != nullptr)
{
texture_floaterp->setTextureSelectedCallback(mOnTextureSelectedCallback);
}
- if (mOnCloseCallback)
+ if (mOnCloseCallback != nullptr)
{
texture_floaterp->setOnFloaterCloseCallback(boost::bind(&LLTextureCtrl::onFloaterClose, this));
}
@@ -1236,7 +1236,7 @@ void LLTextureCtrl::closeDependentFloater()
LLFloaterTexturePicker* floaterp = (LLFloaterTexturePicker*)mFloaterHandle.get();
if( floaterp )
{
- floaterp->setOwner(NULL);
+ floaterp->setOwner(nullptr);
floaterp->closeFloater();
}
}
@@ -1292,11 +1292,11 @@ void LLTextureCtrl::onFloaterClose()
if (floaterp)
{
- if (mOnCloseCallback)
+ if (mOnCloseCallback != nullptr)
{
mOnCloseCallback(this,LLSD());
}
- floaterp->setOwner(NULL);
+ floaterp->setOwner(nullptr);
}
mFloaterHandle.markDead();
@@ -1333,11 +1333,11 @@ void LLTextureCtrl::onFloaterCommit(ETexturePickOp op, LLUUID id)
LL_DEBUGS() << "mImageAssetID: " << mImageAssetID << LL_ENDL;
}
- if (op == TEXTURE_SELECT && mOnSelectCallback)
+ if (op == TEXTURE_SELECT && mOnSelectCallback != nullptr)
{
mOnSelectCallback( this, LLSD() );
}
- else if (op == TEXTURE_CANCEL && mOnCancelCallback)
+ else if (op == TEXTURE_CANCEL && mOnCancelCallback != nullptr)
{
mOnCancelCallback( this, LLSD() );
}
@@ -1442,7 +1442,7 @@ void LLTextureCtrl::draw()
if (!mValid)
{
- mTexturep = NULL;
+ mTexturep = nullptr;
}
else if (!mImageAssetID.isNull())
{
@@ -1455,7 +1455,7 @@ void LLTextureCtrl::draw()
}
else//mImageAssetID == LLUUID::null
{
- mTexturep = NULL;
+ mTexturep = nullptr;
}
// Border
@@ -1560,7 +1560,7 @@ BOOL LLTextureCtrl::allowDrop(LLInventoryItem* item)
PermissionMask filter_perm_mask = mImmediateFilterPermMask;
if ( (item_perm_mask & filter_perm_mask) == filter_perm_mask )
{
- if(mDragCallback)
+ if(mDragCallback != nullptr)
{
return mDragCallback(this, item);
}
@@ -1578,7 +1578,7 @@ BOOL LLTextureCtrl::allowDrop(LLInventoryItem* item)
BOOL LLTextureCtrl::doDrop(LLInventoryItem* item)
{
// call the callback if it exists.
- if(mDropCallback)
+ if(mDropCallback != nullptr)
{
// if it returns TRUE, we return TRUE, and therefore the
// commit is called above.
diff --git a/indra/newview/lltexturectrl.h b/indra/newview/lltexturectrl.h
index 8a4bbfb5f6..33ec5511fb 100644
--- a/indra/newview/lltexturectrl.h
+++ b/indra/newview/lltexturectrl.h
@@ -244,10 +244,10 @@ private:
//////////////////////////////////////////////////////////////////////////////////////////
// LLFloaterTexturePicker
-typedef boost::function<void(LLTextureCtrl::ETexturePickOp op, LLUUID id)> floater_commit_callback;
-typedef boost::function<void()> floater_close_callback;
-typedef boost::function<void(const LLUUID& asset_id)> set_image_asset_id_callback;
-typedef boost::function<void(LLPointer<LLViewerTexture> texture)> set_on_update_image_stats_callback;
+typedef std::function<void(LLTextureCtrl::ETexturePickOp op, LLUUID id)> floater_commit_callback;
+typedef std::function<void()> floater_close_callback;
+typedef std::function<void(const LLUUID& asset_id)> set_image_asset_id_callback;
+typedef std::function<void(LLPointer<LLViewerTexture> texture)> set_on_update_image_stats_callback;
class LLFloaterTexturePicker : public LLFloater
{
diff --git a/indra/newview/lltranslate.cpp b/indra/newview/lltranslate.cpp
index 1bf8477267..532cae0499 100644
--- a/indra/newview/lltranslate.cpp
+++ b/indra/newview/lltranslate.cpp
@@ -154,7 +154,7 @@ void LLTranslationAPIHandler::verifyKeyCoro(LLTranslate::EService service, std::
if (!status)
bOk = false;
- if (!fnc.empty())
+ if (fnc != nullptr)
fnc(service, bOk);
}
@@ -208,7 +208,7 @@ void LLTranslationAPIHandler::translateMessageCoro(LanguagePair_t fromTo, std::s
LLStringUtil::replaceString(translation, "&", "&");
LLStringUtil::replaceString(translation, "'", "'");
- if (!success.empty())
+ if (success != nullptr)
success(translation, detected_lang);
}
else
@@ -219,7 +219,7 @@ void LLTranslationAPIHandler::translateMessageCoro(LanguagePair_t fromTo, std::s
}
LL_WARNS() << "Translation request failed: " << err_msg << LL_ENDL;
- if (!failure.empty())
+ if (failure != nullptr)
failure(status, err_msg);
}
diff --git a/indra/newview/lltranslate.h b/indra/newview/lltranslate.h
index 938730757d..6063a8c73c 100644
--- a/indra/newview/lltranslate.h
+++ b/indra/newview/lltranslate.h
@@ -56,9 +56,9 @@ public :
SERVICE_GOOGLE,
} EService;
- typedef boost::function<void(EService, bool)> KeyVerificationResult_fn;
- typedef boost::function<void(std::string , std::string )> TranslationSuccess_fn;
- typedef boost::function<void(int, std::string)> TranslationFailure_fn;
+ typedef std::function<void(EService, bool)> KeyVerificationResult_fn;
+ typedef std::function<void(std::string , std::string )> TranslationSuccess_fn;
+ typedef std::function<void(int, std::string)> TranslationFailure_fn;
/**
* Translate given text.
diff --git a/indra/newview/llviewerassetupload.h b/indra/newview/llviewerassetupload.h
index 976562f9e5..cc02aebaf3 100644
--- a/indra/newview/llviewerassetupload.h
+++ b/indra/newview/llviewerassetupload.h
@@ -165,8 +165,8 @@ private:
class LLBufferedAssetUploadInfo : public LLResourceUploadInfo
{
public:
- typedef boost::function<void(LLUUID itemId, LLUUID newAssetId, LLUUID newItemId, LLSD response)> invnUploadFinish_f;
- typedef boost::function<void(LLUUID itemId, LLUUID taskId, LLUUID newAssetId, LLSD response)> taskUploadFinish_f;
+ typedef std::function<void(LLUUID itemId, LLUUID newAssetId, LLUUID newItemId, LLSD response)> invnUploadFinish_f;
+ typedef std::function<void(LLUUID itemId, LLUUID taskId, LLUUID newAssetId, LLSD response)> taskUploadFinish_f;
LLBufferedAssetUploadInfo(LLUUID itemId, LLAssetType::EType assetType, std::string buffer, invnUploadFinish_f finish);
LLBufferedAssetUploadInfo(LLUUID itemId, LLPointer<LLImageFormatted> image, invnUploadFinish_f finish);
diff --git a/indra/newview/llvoicevivox.h b/indra/newview/llvoicevivox.h
index de3f6a7a6a..0fb21db317 100644
--- a/indra/newview/llvoicevivox.h
+++ b/indra/newview/llvoicevivox.h
@@ -306,7 +306,7 @@ protected:
typedef boost::shared_ptr<sessionState> ptr_t;
typedef boost::weak_ptr<sessionState> wptr_t;
- typedef boost::function<void(const ptr_t &)> sessionFunc_t;
+ typedef std::function<void(const ptr_t &)> sessionFunc_t;
static ptr_t createSession();
~sessionState();
--
GitLab