Commit 5e039be3 authored by callum_linden's avatar callum_linden
Browse files

Update scripts to point to the CEF 3202 revision (Chrome 62) and tweak a line...

Update scripts to point to the CEF 3202 revision (Chrome 62) and tweak a line that caused a crash on exit in this version of CEF
parent 6d1650d8
......@@ -33,7 +33,7 @@ Building CEF locally is quite a dauting task and needs a toolset I do not have o
## Which version of CEF does Dullahan use?
Dullahan currently builds against the [CEF 3.3029.1611.g44e39a8 / Chromium 58.0.3029.81](http://opensource.spotify.com/cefbuilds/index.html) build of CEF but with some small tweaks to take account of CEF interface changes etc. it should work with slightly older or more recent versions too.
Dullahan currently builds against the [CEF 3.3202.1686.gd665578 / Chromium 62](http://opensource.spotify.com/cefbuilds/index.html) build of CEF but with some small tweaks to take account of CEF interface changes etc. it should work with slightly older or more recent versions too.
## What are the origins of this project?
......
......@@ -104,8 +104,9 @@ void dullahan_browser_client::OnBeforeClose(CefRefPtr<CefBrowser> browser)
if (mBrowserList.empty())
{
// TODO: mark this call as only needed if using CEFs message loop and not CefDoMessageLoopWork()
CefQuitMessageLoop();
// TODO: add code to only call this when we are using CEF's
// message loop and not using our own along side CefDoMessageLoopWork()
//CefQuitMessageLoop();
mParent->getCallbackManager()->onRequestExit();
}
......
@pushd .
@if exist build_win.bat cd ..
set CEF_32_DIR="c:\work\cef_builds\cef_3071.1649.g98725e6_windows32"
set CEF_64_DIR="C:\work\cef_builds\cef_3071.1649.g98725e6_windows64"
rem We are using the CEF 3202 branch (like Chrome 62) version that we built
rem from the Spotify CEF site using make_dullahan_cef_pkg.bat script in this folder.
set CEF_32_DIR="c:\work\cef_builds\cef_3202.1686.gd665578_windows32"
set CEF_64_DIR="C:\work\cef_builds\cef_3202.1686.gd665578_windows64"
@if "%1"=="32" goto BitWidth32
@if "%1"=="64" goto BitWidth64
......
......@@ -2,10 +2,12 @@
rem Edit these variables to point to the uncompressed CEF source directory and
rem the required destination directory for both 32 and 64 bit versions
set SRC_DIR_32="%USERPROFILE%\Desktop\cef_binary_3.3071.1649.g98725e6_windows32"
set DST_DIR_32="%USERPROFILE%\Desktop\cef_3071.1649.g98725e6_windows32"
set SRC_DIR_64="%USERPROFILE%\Desktop\cef_binary_3.3071.1649.g98725e6_windows64"
set DST_DIR_64="%USERPROFILE%\Desktop\cef_3071.1649.g98725e6_windows64"
rem Note: I get the "src" CEF packages from the Spotify CEF builds site
rem here http://opensource.spotify.com/cefbuilds/index.html
set SRC_DIR_32="%USERPROFILE%\Desktop\cef_binary_3.3202.1686.gd665578_windows32"
set DST_DIR_32="%USERPROFILE%\Desktop\cef_3202.1686.gd665578_windows32"
set SRC_DIR_64="%USERPROFILE%\Desktop\cef_binary_3.3202.1686.gd665578_windows64"
set DST_DIR_64="%USERPROFILE%\Desktop\cef_3202.1686.gd665578_windows64"
@if "%1"=="32" goto BitWidth32
@if "%1"=="64" goto BitWidth64
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment