From 04738a50216a505fb06c8c68d2d225d12f6a4541 Mon Sep 17 00:00:00 2001
From: Rye Mutt <rye@alchemyviewer.org>
Date: Sun, 9 Aug 2020 20:24:27 -0400
Subject: [PATCH] Fix non-virtual dtor warnings
---
indra/llmath/lloctree.h | 2 ++
indra/llui/llbadgeholder.h | 2 ++
indra/llui/llhelp.h | 2 ++
indra/llui/llnotifications.h | 2 ++
indra/llui/llspellcheckmenuhandler.h | 2 ++
indra/newview/lltransientfloatermgr.h | 2 ++
6 files changed, 12 insertions(+)
diff --git a/indra/llmath/lloctree.h b/indra/llmath/lloctree.h
index 0e2f62f9db8..f6d254d1571 100644
--- a/indra/llmath/lloctree.h
+++ b/indra/llmath/lloctree.h
@@ -62,6 +62,8 @@ template <class T>
class LLOctreeTraveler
{
public:
+ virtual ~LLOctreeTraveler() = default;
+
virtual void traverse(const LLOctreeNode<T>* node);
virtual void visit(const LLOctreeNode<T>* branch) = 0;
};
diff --git a/indra/llui/llbadgeholder.h b/indra/llui/llbadgeholder.h
index 2538eaae91c..8af751746b8 100644
--- a/indra/llui/llbadgeholder.h
+++ b/indra/llui/llbadgeholder.h
@@ -42,6 +42,8 @@ class LLBadgeHolder
{
}
+ virtual ~LLBadgeHolder() = default;
+
void setAcceptsBadge(bool acceptsBadge) { mAcceptsBadge = acceptsBadge; }
bool acceptsBadge() const { return mAcceptsBadge; }
diff --git a/indra/llui/llhelp.h b/indra/llui/llhelp.h
index 1726347a783..426d921fe83 100644
--- a/indra/llui/llhelp.h
+++ b/indra/llui/llhelp.h
@@ -31,6 +31,8 @@
class LLHelp
{
public:
+ virtual ~LLHelp() = default;
+
virtual void showTopic(const std::string &topic) = 0;
virtual std::string getURL(const std::string &topic) = 0;
// return default (fallback) topic name suitable for showTopic()
diff --git a/indra/llui/llnotifications.h b/indra/llui/llnotifications.h
index d1e82342798..7def45dd250 100644
--- a/indra/llui/llnotifications.h
+++ b/indra/llui/llnotifications.h
@@ -864,6 +864,8 @@ class LLNotificationChannel :
class LLNotificationsInterface
{
public:
+ virtual ~LLNotificationsInterface() = default;
+
virtual LLNotificationPtr add(const std::string& name,
const LLSD& substitutions,
const LLSD& payload,
diff --git a/indra/llui/llspellcheckmenuhandler.h b/indra/llui/llspellcheckmenuhandler.h
index d5c95bad39a..fdd0ad104d6 100644
--- a/indra/llui/llspellcheckmenuhandler.h
+++ b/indra/llui/llspellcheckmenuhandler.h
@@ -30,6 +30,8 @@
class LLSpellCheckMenuHandler
{
public:
+ virtual ~LLSpellCheckMenuHandler() = default;
+
virtual bool getSpellCheck() const { return false; }
virtual const std::string& getSuggestion(U32 index) const { return LLStringUtil::null; }
diff --git a/indra/newview/lltransientfloatermgr.h b/indra/newview/lltransientfloatermgr.h
index bd3a4a64775..3638564ab15 100644
--- a/indra/newview/lltransientfloatermgr.h
+++ b/indra/newview/lltransientfloatermgr.h
@@ -78,6 +78,8 @@ class LLTransientFloater
*/
void init(LLFloater* thiz);
public:
+ virtual ~LLTransientFloater() = default;
+
virtual LLTransientFloaterMgr::ETransientGroup getGroup() = 0;
bool isTransientDocked() { return mFloater->isDocked(); };
void setTransientVisible(BOOL visible) {mFloater->setVisible(visible); }
--
GitLab