From 33545bb735a7ecafb6023efcc7de0c6e5ab02a09 Mon Sep 17 00:00:00 2001
From: Rye Mutt <rye@alchemyviewer.org>
Date: Tue, 10 Mar 2020 18:20:54 -0400
Subject: [PATCH] Fix potentially uninitialized warning about LLVector4a and
 cleanup dead code

---
 indra/newview/llface.cpp   | 4 ----
 indra/newview/pipeline.cpp | 2 ++
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/indra/newview/llface.cpp b/indra/newview/llface.cpp
index 7b0ea756e3e..00f3b9d3eec 100644
--- a/indra/newview/llface.cpp
+++ b/indra/newview/llface.cpp
@@ -856,9 +856,6 @@ static void xform4a(LLVector4a &tex_coord, const LLVector4a& trans, const LLVect
 	// Texture transforms are done about the center of the face.
 	st.setAdd(tex_coord, trans);
 	
-	// Handle rotation
-	LLVector4a rot_st;
-		
 	// <s0 * cosAng, s0*-sinAng, s1*cosAng, s1*-sinAng>
 	LLVector4a s0;
 	s0.splat(st, 0);
@@ -934,7 +931,6 @@ BOOL LLFace::genVolumeBBoxes(const LLVolume &volume, S32 f,
 		//VECTORIZE THIS
 		LLMatrix4a mat_vert;
 		mat_vert.loadu(mat_vert_in);
-        LLVector4a new_extents[2];
 
 		llassert(less_than_max_mag(face.mExtents[0]));
 		llassert(less_than_max_mag(face.mExtents[1]));
diff --git a/indra/newview/pipeline.cpp b/indra/newview/pipeline.cpp
index 8622e5e3d35..1ac71d26592 100644
--- a/indra/newview/pipeline.cpp
+++ b/indra/newview/pipeline.cpp
@@ -7133,6 +7133,7 @@ LLVOPartGroup* LLPipeline::lineSegmentIntersectParticle(const LLVector4a& start,
 	LLVector4a local_end = end;
 
 	LLVector4a position;
+	position.clear();
 
 	LLDrawable* drawable = NULL;
 
@@ -7184,6 +7185,7 @@ LLViewerObject* LLPipeline::lineSegmentIntersectInWorld(const LLVector4a& start,
 	LLVector4a local_end = end;
 
 	LLVector4a position;
+	position.clear();
 
 	sPickAvatar = false; //! LLToolMgr::getInstance()->inBuildMode();
 	
-- 
GitLab