From 7aff3d0842475de4b0bb3bc33d5b4cc86a056623 Mon Sep 17 00:00:00 2001
From: Nat Goodspeed <nat@lindenlab.com>
Date: Tue, 20 Oct 2009 11:32:45 -0400
Subject: [PATCH] Disabling dubious getHostName() test as explained in
comments
---
indra/llmessage/tests/llhost_test.cpp | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/indra/llmessage/tests/llhost_test.cpp b/indra/llmessage/tests/llhost_test.cpp
index 5dc9ce42ee2..ebe61fcad30 100644
--- a/indra/llmessage/tests/llhost_test.cpp
+++ b/indra/llmessage/tests/llhost_test.cpp
@@ -166,7 +166,21 @@ namespace tut
// the main domain name and not do the exact compare
std::string hostname = host.getHostName();
- ensure("getHostName failed", hostname.find(hostStr) != std::string::npos);
+/*==========================================================================*|
+ // nat 2009-10-20: not sure this ensure() is such a good idea, at
+ // least with "google.com". The logic below is failing for me with:
+ // set 'google.com'; reported 'yx-in-f100.1e100.net'
+ // Disabling test until we can replace it with something more robust.
+ try
+ {
+ ensure("getHostName failed", hostname.find(hostStr) != std::string::npos);
+ }
+ catch (const std::exception&)
+ {
+ std::cerr << "set '" << hostStr << "'; reported '" << hostname << "'" << std::endl;
+ throw;
+ }
+|*==========================================================================*/
}
// setHostByName for dotted IP
--
GitLab