From 9f9856bb0d219de2099539c17f0cda3c15ac2c27 Mon Sep 17 00:00:00 2001 From: Rye Mutt <rye@alchemyviewer.org> Date: Sun, 20 Mar 2022 21:56:45 -0400 Subject: [PATCH] Fix crash on invalid animation request --- indra/newview/llagent.cpp | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/indra/newview/llagent.cpp b/indra/newview/llagent.cpp index 181d0627e18..da101a55db6 100644 --- a/indra/newview/llagent.cpp +++ b/indra/newview/llagent.cpp @@ -3270,13 +3270,16 @@ void LLAgent::sendAnimationRequests(const std::vector<LLUUID> &anim_ids, EAnimRe msg->addBOOLFast(_PREHASH_StartAnim, (request == ANIM_REQUEST_START) ? TRUE : FALSE); num_valid_anims++; } - - msg->nextBlockFast(_PREHASH_PhysicalAvatarEventList); - msg->addBinaryDataFast(_PREHASH_TypeData, NULL, 0); - if (num_valid_anims) + if (!num_valid_anims) { - sendReliableMessage(); + msg->clearMessage(); + return; } + + msg->nextBlockFast(_PREHASH_PhysicalAvatarEventList); + msg->addBinaryDataFast(_PREHASH_TypeData, NULL, 0); + + sendReliableMessage(); } void LLAgent::sendAnimationRequest(const LLUUID &anim_id, EAnimRequest request) -- GitLab