From d194d95391f03b8a60c779f50f830df014e4b71e Mon Sep 17 00:00:00 2001 From: Nathan Wilcox <inoshiro@lindenlab.com> Date: Wed, 13 Jan 2010 16:09:07 -0800 Subject: [PATCH] DEV-44838 - Fix a logic flaw in the windows run() retry code which would re-execute a process if its exit status was 0. --- indra/develop.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/indra/develop.py b/indra/develop.py index a8a7b63aa7f..0a2d3c5e521 100755 --- a/indra/develop.py +++ b/indra/develop.py @@ -596,7 +596,9 @@ def run(self, command, name=None, retry_on=None, retries=1): print "develop.py tries to run:", command ret = subprocess.call(command, executable=path) print "got ret", ret, "from", command - if ret: + if ret == 0: + break + else: error = 'exited with status %d' % ret if retry_on is not None and retry_on == ret: print "Retrying... the command %r %s" % (name, error) -- GitLab