From dfb806310260c13ccdba9780f474d0c0fc8ea0a8 Mon Sep 17 00:00:00 2001
From: Rye Mutt <rye@alchemyviewer.org>
Date: Tue, 10 Aug 2021 08:44:55 -0400
Subject: [PATCH] Fix invalid comparison of std::string::rfind as boolean
instead of comparing to npos
---
indra/newview/llfloaterabout.cpp | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/indra/newview/llfloaterabout.cpp b/indra/newview/llfloaterabout.cpp
index 9b33d9ecc81..786162c3e7e 100644
--- a/indra/newview/llfloaterabout.cpp
+++ b/indra/newview/llfloaterabout.cpp
@@ -389,17 +389,17 @@ void LLFloaterAbout::setUpdateListener()
{
for(vec::const_iterator iter=file_vec.begin(); iter!=file_vec.end(); ++iter)
{
- if ( (iter->rfind(version)))
+ if (iter->rfind(version) != std::string::npos)
{
- if ( (iter->rfind(".done") ) )
+ if (iter->rfind(".done") != std::string::npos)
{
done = true;
}
- else if ( (iter->rfind(".next") ) )
+ else if (iter->rfind(".next") != std::string::npos)
{
next = true;
}
- else if ( (iter->rfind(".skip") ) )
+ else if (iter->rfind(".skip") != std::string::npos)
{
skip = true;
}
--
GitLab