From f4da8cd3738b8dafecad3ab4f8c1d03fafdfd37e Mon Sep 17 00:00:00 2001
From: Ptolemy <ptolemy@lindenlab.com>
Date: Mon, 27 Apr 2020 15:27:31 -0700
Subject: [PATCH] DRTVWR-510 Cleanup: Remove (redundant) last columns from
 Debug Camera matrices as they are static.

---
 indra/newview/llviewerwindow.cpp | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/indra/newview/llviewerwindow.cpp b/indra/newview/llviewerwindow.cpp
index aaba8dfa5c4..7364454b459 100644
--- a/indra/newview/llviewerwindow.cpp
+++ b/indra/newview/llviewerwindow.cpp
@@ -709,32 +709,33 @@ class LLDebugText
 		}
 		if (gSavedSettings.getBOOL("DebugShowRenderMatrices"))
 		{
-			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f    %.4f", gGLProjection[12], gGLProjection[13], gGLProjection[14], gGLProjection[15]));
+            // Projection last column is always <0,0,-1,0>
+			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f", gGLProjection[12], gGLProjection[13], gGLProjection[14]));
 			ypos += y_inc;
 
-			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f    %.4f", gGLProjection[8], gGLProjection[9], gGLProjection[10], gGLProjection[11]));
+			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f", gGLProjection[8], gGLProjection[9], gGLProjection[10]));
 			ypos += y_inc;
 
-			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f    %.4f", gGLProjection[4], gGLProjection[5], gGLProjection[6], gGLProjection[7]));
+			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f", gGLProjection[4], gGLProjection[5], gGLProjection[6]));
 			ypos += y_inc;
 
-			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f    %.4f", gGLProjection[0], gGLProjection[1], gGLProjection[2], gGLProjection[3]));
+			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f", gGLProjection[0], gGLProjection[1], gGLProjection[2]));
 			ypos += y_inc;
 
 			addText(xpos, ypos, "Projection Matrix");
 			ypos += y_inc;
 
-
-			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f    %.4f", gGLModelView[12], gGLModelView[13], gGLModelView[14], gGLModelView[15]));
+            // View last column is always <0,0,0,1>
+			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f", gGLModelView[12], gGLModelView[13], gGLModelView[14]));
 			ypos += y_inc;
 
-			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f    %.4f", gGLModelView[8], gGLModelView[9], gGLModelView[10], gGLModelView[11]));
+			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f", gGLModelView[8], gGLModelView[9], gGLModelView[10]));
 			ypos += y_inc;
 
-			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f    %.4f", gGLModelView[4], gGLModelView[5], gGLModelView[6], gGLModelView[7]));
+			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f", gGLModelView[4], gGLModelView[5], gGLModelView[6]));
 			ypos += y_inc;
 
-			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f    %.4f", gGLModelView[0], gGLModelView[1], gGLModelView[2], gGLModelView[3]));
+			addText(xpos, ypos, llformat("%.4f    %.4f    %.4f", gGLModelView[0], gGLModelView[1], gGLModelView[2]));
 			ypos += y_inc;
 
 			addText(xpos, ypos, "View Matrix");
-- 
GitLab