Skip to content
Snippets Groups Projects
Forked from Alchemy Viewer / Alchemy Viewer
Source project has a limited visibility.
  • Nicky Dasmijn's avatar
    acaa2723
    LLExtStat had been a S32, this wasn't right, as some of the constants lead to... · acaa2723
    Nicky Dasmijn authored
    LLExtStat had been a S32, this wasn't right, as some of the constants lead to integer overflow: const LLExtStat LL_EXSTAT_RES_RESULT = 2L<<30; const LLExtStat LL_EXSTAT_VFS_RESULT = 3L<<30; This shifts into the sign bit and clang gets (rightfully) upset about this.
    
    LLExtStatus needs to be at least of type U32 to remedy this problem, but
    while at it it makes sense to turn it into what it is: An enum. Turning
    it into a class enum has the added benefit we get type safety for mostly
    free.
    Which incidentally turned up a problem right away:
    A call to removeAndCallbackPendingDownloads had status and extstatus
    reversed and thus was wrong.
    acaa2723
    History
    LLExtStat had been a S32, this wasn't right, as some of the constants lead to...
    Nicky Dasmijn authored
    LLExtStat had been a S32, this wasn't right, as some of the constants lead to integer overflow: const LLExtStat LL_EXSTAT_RES_RESULT = 2L<<30; const LLExtStat LL_EXSTAT_VFS_RESULT = 3L<<30; This shifts into the sign bit and clang gets (rightfully) upset about this.
    
    LLExtStatus needs to be at least of type U32 to remedy this problem, but
    while at it it makes sense to turn it into what it is: An enum. Turning
    it into a class enum has the added benefit we get type safety for mostly
    free.
    Which incidentally turned up a problem right away:
    A call to removeAndCallbackPendingDownloads had status and extstatus
    reversed and thus was wrong.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.