SL-19690: Follow up on Rye Mutt's fix for shutdown crashes.
Rather than continuing to propagate try/catch (Closed) (aka LLThreadSafeQueueInterrupt) constructs through the code base, make WorkQueueBase::post() return bool indicating success (i.e. ! isClosed()). This obviates postIfOpen(), which no one was using anyway. In effect, postIfOpen() is renamed post(), bypassing the exception when isClosed(). Review existing try/catch blocks of that sort, changing to test for post() returning false.
Showing
- indra/llaudio/llaudiodecodemgr.cpp 29 additions, 32 deletionsindra/llaudio/llaudiodecodemgr.cpp
- indra/llcommon/llqueuedthread.cpp 1 addition, 1 deletionindra/llcommon/llqueuedthread.cpp
- indra/llcommon/workqueue.cpp 3 additions, 18 deletionsindra/llcommon/workqueue.cpp
- indra/llcommon/workqueue.h 53 additions, 82 deletionsindra/llcommon/workqueue.h
- indra/llimage/llimageworker.cpp 13 additions, 15 deletionsindra/llimage/llimageworker.cpp
- indra/llrender/llimagegl.h 1 addition, 1 deletionindra/llrender/llimagegl.h
- indra/llwindow/llwindowwin32.cpp 4 additions, 9 deletionsindra/llwindow/llwindowwin32.cpp
Loading
Please register or sign in to comment