Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
XDG Integration
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Silent mode is enabled
All outbound communications are blocked.
Learn more
.
Show more breadcrumbs
JennaHuntsman
XDG Integration
Commits
07a830a4
Commit
07a830a4
authored
1 year ago
by
Cosmic Linden
Browse files
Options
Downloads
Patches
Plain Diff
SL-20062: Fix near clip on reflection probes being clamped to at or below 10
parent
5473c0e2
No related branches found
No related tags found
2 merge requests
!3
Update to main branch
,
!2
Rebase onto current main branch
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
indra/llmath/llcamera.h
+1
-1
1 addition, 1 deletion
indra/llmath/llcamera.h
indra/llprimitive/llprimitive.cpp
+2
-0
2 additions, 0 deletions
indra/llprimitive/llprimitive.cpp
with
3 additions
and
1 deletion
indra/llmath/llcamera.h
+
1
−
1
View file @
07a830a4
...
...
@@ -39,7 +39,7 @@ const F32 DEFAULT_NEAR_PLANE = 0.25f;
const
F32
DEFAULT_FAR_PLANE
=
64.
f
;
// far reaches across two horizontal, not diagonal, regions
const
F32
MAX_ASPECT_RATIO
=
50.0
f
;
const
F32
MAX_NEAR_PLANE
=
10
.
f
;
const
F32
MAX_NEAR_PLANE
=
10
23.9
f
;
// Clamp the near plane just before the skybox ends
const
F32
MAX_FAR_PLANE
=
100000.0
f
;
//1000000.0f; // Max allowed. Not good Z precision though.
const
F32
MAX_FAR_CLIP
=
512.0
f
;
...
...
This diff is collapsed.
Click to expand it.
indra/llprimitive/llprimitive.cpp
+
2
−
0
View file @
07a830a4
...
...
@@ -85,6 +85,8 @@ const F32 LIGHT_MAX_CUTOFF = 180.f;
const
F32
REFLECTION_PROBE_MIN_AMBIANCE
=
0.
f
;
const
F32
REFLECTION_PROBE_MAX_AMBIANCE
=
100.
f
;
const
F32
REFLECTION_PROBE_DEFAULT_AMBIANCE
=
0.
f
;
// *NOTE: Clip distances are clamped in LLCamera::setNear. The max clip
// distance is currently limited by the skybox
const
F32
REFLECTION_PROBE_MIN_CLIP_DISTANCE
=
0.
f
;
const
F32
REFLECTION_PROBE_MAX_CLIP_DISTANCE
=
1024.
f
;
const
F32
REFLECTION_PROBE_DEFAULT_CLIP_DISTANCE
=
0.
f
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment