EXT-7755 ADDITIONAL FIX Fixed issues with wrong title after an outfit from the...

EXT-7755 ADDITIONAL FIX Fixed issues with wrong title after an outfit from the Inventory is worn, "Wear..." menu items state is made consistent with "Wear" button.

* Empty string is replaced with "Changing outfits" while changing COF;
* Fixed title to show "No Outfit" after an outfit from the Inventory is worn;
* Fixed bug with visible indicator after an empty folder is DnD from the Inventory "Clothing"
* Updated context and Gear "Wear..." menu items to take into account "isCOFChangeInProgress" state in on_enable callbacks

Reviewed by Neal Orman at https://codereview.productengine.com/secondlife/r/625/

--HG--
branch : product-engine

indra/newview/llappearancemgr.cpp

@@ -1697,9 +1697,10 @@ void LLAppearanceMgr::getUserDescendents(const LLUUID& category,
 
 void LLAppearanceMgr::wearInventoryCategory(LLInventoryCategory* category, bool copy, bool append)
 {
-	gAgentWearables.notifyLoadingStarted();
 	if(!category) return;
 
+	gAgentWearables.notifyLoadingStarted();
+
 	llinfos << "wearInventoryCategory( " << category->getName()
 			 << " )" << llendl;
 

indra/newview/llappearancemgr.h

@@ -360,6 +360,9 @@ class CallAfterCategoryFetchStage1: public LLInventoryFetchDescendentsObserver
 					<< llendl;
 			//dec_busy_count();
 			gInventory.removeObserver(this);
+
+			// lets notify observers that loading is finished.
+			gAgentWearables.notifyLoadingFinished();
 			delete this;
 			return;
 		}

indra/newview/lloutfitslist.cpp

@@ -103,8 +103,13 @@ class OutfitContextMenu : public LLListContextMenu
 		{
 			return get_is_category_renameable(&gInventory, outfit_cat_id);
 		}
+		else if ("wear_replace" == param)
+		{
+			return !gAgentWearables.isCOFChangeInProgress();
+		}
 		else if ("wear_add" == param)
 		{
+			if (gAgentWearables.isCOFChangeInProgress()) return false;
 			return LLAppearanceMgr::getCanAddToCOF(outfit_cat_id);
 		}
 		else if ("take_off" == param)

indra/newview/llpaneloutfitsinventory.cpp

@@ -72,11 +72,13 @@ static const std::string COF_TAB_NAME = "cof_tab";
 
 static LLRegisterPanelClassWrapper<LLPanelOutfitsInventory> t_inventory("panel_outfits_inventory");
 
+class LLPanelOutfitsInventory;
 class LLOutfitListGearMenu
 {
 public:
-	LLOutfitListGearMenu(LLOutfitsList* olist)
+	LLOutfitListGearMenu(LLOutfitsList* olist, LLPanelOutfitsInventory* parent_panel)
 	:	mOutfitList(olist),
+		mMyOutfitsPanel(parent_panel),
 		mMenu(NULL)
 	{
 		llassert_always(mOutfitList);
@@ -209,6 +211,11 @@ class LLOutfitListGearMenu
 		{
 			return LLAppearanceMgr::getCanRemoveFromCOF(selected_outfit_id);
 		}
+		else if ("wear" == param)
+		{
+			return mMyOutfitsPanel->isActionEnabled(param);
+		}
+
 
 		return true;
 	}
@@ -233,6 +240,7 @@ class LLOutfitListGearMenu
 
 	LLOutfitsList*	mOutfitList;
 	LLMenuGL*		mMenu;
+	LLPanelOutfitsInventory* mMyOutfitsPanel;
 };
 
 LLPanelOutfitsInventory::LLPanelOutfitsInventory() :
@@ -550,13 +558,13 @@ void LLPanelOutfitsInventory::initListCommandsHandlers()
 				   ,       _7 // EAcceptance* accept
 				   ));
 
-	mGearMenu = new LLOutfitListGearMenu(mMyOutfitsPanel);
+	mGearMenu = new LLOutfitListGearMenu(mMyOutfitsPanel, this);
 }
 
 void LLPanelOutfitsInventory::updateListCommands()
 {
 	bool trash_enabled = isActionEnabled("delete");
-	bool wear_enabled =  !gAgentWearables.isCOFChangeInProgress() && isActionEnabled("wear");
+	bool wear_enabled =  isActionEnabled("wear");
 	bool wear_visible = !isCOFPanelActive();
 	bool make_outfit_enabled = isActionEnabled("save_outfit");
 
@@ -710,6 +718,8 @@ BOOL LLPanelOutfitsInventory::isActionEnabled(const LLSD& userdata)
 	
 	if (command_name == "wear")
 	{
+		if (gAgentWearables.isCOFChangeInProgress()) return FALSE;
+
 		if (isCOFPanelActive())
 		{
 			return FALSE;

indra/newview/llpaneloutfitsinventory.h

@@ -112,6 +112,9 @@ class LLPanelOutfitsInventory : public LLPanel
 
 	//////////////////////////////////////////////////////////////////////////////////
 	// List Commands                                                                //
+public:
+	BOOL isActionEnabled(const LLSD& command_name);
+
 protected:
 	void initListCommandsHandlers();
 	void updateListCommands();
@@ -119,7 +122,6 @@ class LLPanelOutfitsInventory : public LLPanel
 	void showGearMenu();
 	void onTrashButtonClick();
 	void onClipboardAction(const LLSD& userdata);
-	BOOL isActionEnabled(const LLSD& command_name);
 	void onCustomAction(const LLSD& command_name);
 	bool handleDragAndDropToTrash(BOOL drop, EDragAndDropType cargo_type, EAcceptance* accept);
 	bool hasItemsSelected();

indra/newview/llsidepanelappearance.cpp

@@ -390,8 +390,8 @@ void LLSidepanelAppearance::refreshCurrentOutfitName(const std::string& name)
 				return;
 		}
 
-		std::string look_name = gAgentWearables.isCOFChangeInProgress() ? "" : getString("No Outfit");
-		mCurrentLookName->setText(look_name);
+		std::string string_name = gAgentWearables.isCOFChangeInProgress() ? "Changing outfits" : "No Outfit";
+		mCurrentLookName->setText(getString(string_name));
 		mOpenOutfitBtn->setEnabled(FALSE);
 	}
 	else
@@ -475,6 +475,12 @@ void LLSidepanelAppearance::setWearablesLoading(bool val)
 {
 	childSetVisible("wearables_loading_indicator", val);
 	childSetVisible("edit_outfit_btn", !val);
+
+	if (!val)
+	{
+		// refresh outfit name when COF is already changed.
+		refreshCurrentOutfitName();
+	}
 }
 
 void LLSidepanelAppearance::showDefaultSubpart()

indra/newview/skins/default/xui/en/menu_outfit_tab.xml

@@ -8,6 +8,9 @@
      name="wear_replace">
         <on_click
          function="Outfit.WearReplace" />
+        <on_enable
+         function="Outfit.OnEnable"
+         parameter="wear_replace" />
         <on_visible
          function="Outfit.OnVisible"
          parameter="wear_replace" />

indra/newview/skins/default/xui/en/sidepanel_appearance.xml

@@ -21,6 +21,9 @@ width="333">
    <string
    name="Now Wearing"
    value="Now wearing..." />
+   <string
+   name="Changing outfits"
+   value="Changing outfits" />
    <panel
    background_opaque="true"
    background_visible="true"