-
- Downloads
SL-18837: Avoid stuffing build number into 32-bit int.
Even though LLVersionInfo::getBuild() already returns a 64-bit int, various consumers assumed it could fit into 32 bits. It was especially bad to pass it to a classic C style varargs function. Only on a little-endian CPU, and only because it was the last argument, the damage was limited to truncation -- instead of arbitrary undefined behavior. Where the consumer doesn't support 64-bit ints, pass as string instead.
parent
19f453fc
No related branches found
No related tags found
Showing
- indra/newview/llappviewer.cpp 3 additions, 1 deletionindra/newview/llappviewer.cpp
- indra/newview/llcurrencyuimanager.cpp 9 additions, 4 deletionsindra/newview/llcurrencyuimanager.cpp
- indra/newview/llpanellogin.cpp 6 additions, 7 deletionsindra/newview/llpanellogin.cpp
- indra/newview/lltranslate.cpp 13 additions, 12 deletionsindra/newview/lltranslate.cpp
- indra/newview/llversioninfo.cpp 2 additions, 2 deletionsindra/newview/llversioninfo.cpp
- indra/newview/llversioninfo.h 1 addition, 1 deletionindra/newview/llversioninfo.h
- indra/newview/llxmlrpctransaction.cpp 8 additions, 7 deletionsindra/newview/llxmlrpctransaction.cpp
Loading
Please register or sign in to comment