Change many empty constructor and destructor to default for better compiler optimization

indra/llappearance/llavatarappearance.h

@@ -60,11 +60,10 @@ class LLAvatarAppearance : public LLCharacter
  **                                                                            **
  **                    INITIALIZATION
  **/
-private:
-	// Hide default constructor.
-	LLAvatarAppearance() {}
-
 public:
+	// Delete the default constructor. Force construction with wearable data
+	LLAvatarAppearance() = delete;
+
 	LLAvatarAppearance(LLWearableData* wearable_data);
 	virtual ~LLAvatarAppearance();
 

indra/llappearance/lldriverparam.h

@@ -80,10 +80,10 @@ class LLDriverParamInfo final : public LLViewerVisualParamInfo
 LL_ALIGN_PREFIX(16)
 class LLDriverParam final : public LLViewerVisualParam
 {
-private:
-	// Hide the default constructor.  Force construction with LLAvatarAppearance.
-	LLDriverParam() {}
 public:
+	// Delete the default constructor.  Force construction with LLAvatarAppearance.
+	LLDriverParam() = delete;
+
 	LLDriverParam(LLAvatarAppearance *appearance, LLWearable* wearable = NULL);
 	~LLDriverParam() = default;
 

indra/llappearance/llpolyskeletaldistortion.cpp

@@ -41,10 +41,6 @@
 //-----------------------------------------------------------------------------
 // LLPolySkeletalDistortionInfo()
 //-----------------------------------------------------------------------------
-LLPolySkeletalDistortionInfo::LLPolySkeletalDistortionInfo()
-{
-}
-
 BOOL LLPolySkeletalDistortionInfo::parseXml(LLXmlTreeNode* node)
 {
         llassert( node->hasName( "param" ) && node->getChildByName( "param_skeleton" ) );
@@ -117,15 +113,6 @@ LLPolySkeletalDistortion::LLPolySkeletalDistortion(LLAvatarAppearance *avatarp)
 //-----------------------------------------------------------------------------
 // LLPolySkeletalDistortion()
 //-----------------------------------------------------------------------------
-LLPolySkeletalDistortion::LLPolySkeletalDistortion(const LLPolySkeletalDistortion &pOther)
-	: LLViewerVisualParam(pOther),
-	mDefaultVec(pOther.mDefaultVec),
-	mJointScales(pOther.mJointScales),
-	mJointOffsets(pOther.mJointOffsets),
-	mAvatar(pOther.mAvatar)
-{
-}
-
 BOOL LLPolySkeletalDistortion::setInfo(LLPolySkeletalDistortionInfo *info)
 {
     if (info->mID < 0)

indra/llappearance/llpolyskeletaldistortion.h

@@ -68,7 +68,7 @@ class LLPolySkeletalDistortionInfo : public LLViewerVisualParamInfo
 	friend class LLPolySkeletalDistortion;
 public:
 	
-	LLPolySkeletalDistortionInfo();
+	LLPolySkeletalDistortionInfo() = default;
 	/*virtual*/ ~LLPolySkeletalDistortionInfo() = default;
 	
 	/*virtual*/ BOOL parseXml(LLXmlTreeNode* node);
@@ -131,7 +131,7 @@ class LLPolySkeletalDistortion : public LLViewerVisualParam
 	/*virtual*/ const LLVector4a*	getNextDistortion(U32 *index, LLPolyMesh **poly_mesh){index = 0; poly_mesh = NULL; return NULL;};
 
 protected:
-	LLPolySkeletalDistortion(const LLPolySkeletalDistortion& pOther);
+	LLPolySkeletalDistortion(const LLPolySkeletalDistortion& pOther) = default;
 
 	LL_ALIGN_16(LLVector4a mDefaultVec);
 	typedef std::map<LLJoint*, LLVector3> joint_vec_map_t;

indra/llappearance/lltexglobalcolor.cpp

@@ -93,12 +93,6 @@ LLTexParamGlobalColor::LLTexParamGlobalColor(LLTexGlobalColor* tex_global_color)
 //-----------------------------------------------------------------------------
 // LLTexParamGlobalColor
 //-----------------------------------------------------------------------------
-LLTexParamGlobalColor::LLTexParamGlobalColor(const LLTexParamGlobalColor& pOther)
-	: LLTexLayerParamColor(pOther),
-	mTexGlobalColor(pOther.mTexGlobalColor)
-{
-}
-
 /*virtual*/ LLViewerVisualParam* LLTexParamGlobalColor::cloneParam(LLWearable* wearable) const
 {
 	return new LLTexParamGlobalColor(*this);
@@ -113,11 +107,6 @@ void LLTexParamGlobalColor::onGlobalColorChanged()
 // LLTexGlobalColorInfo
 //-----------------------------------------------------------------------------
 
-LLTexGlobalColorInfo::LLTexGlobalColorInfo()
-{
-}
-
-
 LLTexGlobalColorInfo::~LLTexGlobalColorInfo()
 {
 	for_each(mParamColorInfoList.begin(), mParamColorInfoList.end(), DeletePointer());

indra/llappearance/lltexglobalcolor.h

@@ -61,7 +61,7 @@ class LLTexGlobalColorInfo
 {
 	friend class LLTexGlobalColor;
 public:
-	LLTexGlobalColorInfo();
+	LLTexGlobalColorInfo() = default;
 	~LLTexGlobalColorInfo();
 
 	BOOL parseXml(LLXmlTreeNode* node);
@@ -78,7 +78,7 @@ class LLTexParamGlobalColor : public LLTexLayerParamColor
 	virtual ~LLTexParamGlobalColor() = default;
 	/*virtual*/ LLViewerVisualParam* cloneParam(LLWearable* wearable) const;
 protected:
-	LLTexParamGlobalColor(const LLTexParamGlobalColor& pOther);
+	LLTexParamGlobalColor(const LLTexParamGlobalColor& pOther) = default;
 	/*virtual*/ void onGlobalColorChanged();
 private:
 	LLTexGlobalColor*		mTexGlobalColor;

indra/llappearance/lltexlayerparams.cpp

@@ -62,13 +62,6 @@ LLTexLayerParam::LLTexLayerParam(LLAvatarAppearance *appearance)
 {
 }
 
-LLTexLayerParam::LLTexLayerParam(const LLTexLayerParam& pOther)
-	: LLViewerVisualParam(pOther),
-	mTexLayer(pOther.mTexLayer),
-	mAvatarAppearance(pOther.mAvatarAppearance)
-{
-}
-
 BOOL LLTexLayerParam::setInfo(LLViewerVisualParamInfo *info, BOOL add_to_appearance)
 {
 	LLViewerVisualParam::setInfo(info);
@@ -433,12 +426,6 @@ LLTexLayerParamColor::LLTexLayerParamColor(LLAvatarAppearance *appearance)
 {
 }
 
-LLTexLayerParamColor::LLTexLayerParamColor(const LLTexLayerParamColor& pOther)
-	: LLTexLayerParam(pOther),
-	mAvgDistortionVec(pOther.mAvgDistortionVec)
-{
-}
-
 /*virtual*/ LLViewerVisualParam* LLTexLayerParamColor::cloneParam(LLWearable* wearable) const
 {
 	return new LLTexLayerParamColor(*this);

indra/llappearance/lltexlayerparams.h

@@ -52,7 +52,7 @@ class LLTexLayerParam : public LLViewerVisualParam
 	/*virtual*/ LLViewerVisualParam* cloneParam(LLWearable* wearable) const = 0;
 
 protected:
-	LLTexLayerParam(const LLTexLayerParam& pOther);
+	LLTexLayerParam(const LLTexLayerParam& pOther) = default;
 
 	LLTexLayerInterface*	mTexLayer;
 	LLAvatarAppearance*		mAvatarAppearance;
@@ -194,7 +194,7 @@ class LLTexLayerParamColor : public LLTexLayerParam
 	// New functions
 	LLColor4				getNetColor() const;
 protected:
-	LLTexLayerParamColor(const LLTexLayerParamColor& pOther);
+	LLTexLayerParamColor(const LLTexLayerParamColor& pOther) = default;
 
 	virtual void onGlobalColorChanged() {}
 private:

indra/llappearance/llviewervisualparam.cpp

@@ -123,14 +123,6 @@ LLViewerVisualParam::LLViewerVisualParam()
 {
 }
 
-//-----------------------------------------------------------------------------
-// LLViewerVisualParam()
-//-----------------------------------------------------------------------------
-LLViewerVisualParam::LLViewerVisualParam(const LLViewerVisualParam& pOther)
-	: LLVisualParam(pOther)
-{
-}
-
 //-----------------------------------------------------------------------------
 // setInfo()
 //-----------------------------------------------------------------------------

indra/llappearance/llviewervisualparam.h

@@ -106,7 +106,7 @@ class LLViewerVisualParam : public LLVisualParam
 	BOOL				getCrossWearable() const 	{ return getInfo()->mCrossWearable; }
 
 protected:
-	LLViewerVisualParam(const LLViewerVisualParam& pOther);
+	LLViewerVisualParam(const LLViewerVisualParam& pOther) = default;
 } LL_ALIGN_POSTFIX(16);
 
 #endif // LL_LLViewerVisualParam_H

indra/llappearance/llwearabletype.cpp

@@ -66,10 +66,6 @@ LLWearableType::LLWearableType(LLTranslationBridge::ptr_t &trans)
 {
 }
 
-LLWearableType::~LLWearableType()
-{
-}
-
 void LLWearableType::initSingleton()
 {
 }

indra/llappearance/llwearabletype.h

@@ -36,7 +36,7 @@
 class LLWearableType final : public LLParamSingleton<LLWearableType>
 {
 	LLSINGLETON(LLWearableType, LLTranslationBridge::ptr_t &trans);
-	~LLWearableType();
+	~LLWearableType() = default;
 	void initSingleton() override;
 public: 
 	enum EType
@@ -109,7 +109,7 @@ class LLWearableType final : public LLParamSingleton<LLWearableType>
     {
     public:
         LLWearableDictionary(LLTranslationBridge::ptr_t& trans);
-        ~LLWearableDictionary() {}
+        ~LLWearableDictionary() = default;
     };
 
     LLWearableDictionary mDictionary;

indra/llaudio/llaudiodecodemgr.cpp

@@ -68,7 +68,7 @@ class LLVorbisDecodeState final : public LLRefCount
 	{
 	public:
 		WriteResponder(LLVorbisDecodeState* decoder) : mDecoder(decoder) {}
-		~WriteResponder() {}
+		~WriteResponder() = default;
 		void completed(S32 bytes)
 		{
 			mDecoder->ioComplete(bytes);
@@ -542,8 +542,8 @@ class LLAudioDecodeMgr::Impl
 {
 	friend class LLAudioDecodeMgr;
 public:
-	Impl() {};
-	~Impl() {};
+	Impl() = default;
+	~Impl() = default;
 
 	void processQueue(const F32 num_secs = 0.005);
 

indra/llcommon/llallocator_heap_profile.h

@@ -55,9 +55,7 @@ class LLAllocatorHeapProfile
 
     typedef std::vector<line> lines_t;
 
-    LLAllocatorHeapProfile()
-    {
-    }
+    LLAllocatorHeapProfile() = default;
 
 	void parse(std::string const & prof_text);
 

indra/llcommon/llcallstack.cpp

@@ -115,10 +115,6 @@ std::ostream& operator<<(std::ostream& s, const LLCallStack& call_stack)
     return s;
 }
 
-LLContextStrings::LLContextStrings()
-{
-}
-
 // static
 LLContextStrings* LLContextStrings::getThreadLocalInstance()
 {

indra/llcommon/llcallstack.h

@@ -46,7 +46,7 @@ LL_COMMON_API std::ostream& operator<<(std::ostream& s, const LLCallStack& call_
 class LLContextStrings
 {
 public:
-    LLContextStrings();
+    LLContextStrings() = default;
     static void addContextString(const std::string& str);
     static void removeContextString(const std::string& str);
     static void output(std::ostream& os);

indra/llcommon/llcoros.cpp

@@ -133,10 +133,6 @@ LLCoros::LLCoros():
 {
 }
 
-LLCoros::~LLCoros()
-{
-}
-
 void LLCoros::cleanupSingleton()
 {
     // Some of the coroutines (like voice) will depend onto

indra/llcommon/llcoros.h

@@ -88,9 +88,9 @@ namespace boost {
 class LL_COMMON_API LLCoros final : public LLSingleton<LLCoros>
 {
     LLSINGLETON(LLCoros);
-    ~LLCoros();
+    ~LLCoros() = default;
 
-    void cleanupSingleton();
+    void cleanupSingleton() override;
 public:
     /// The viewer's use of the term "coroutine" became deeply embedded before
     /// the industry term "fiber" emerged to distinguish userland threads from

indra/llcommon/lldependencies.h

@@ -171,7 +171,7 @@ std::ostream& LLDependencies_describe(std::ostream& out, const std::string& key)
  */
 struct LLDependenciesEmpty
 {
-    LLDependenciesEmpty() {}
+    LLDependenciesEmpty() = default;
     /**
      * Give it a constructor accepting void* so caller can pass placeholder
      * values such as NULL or 0 rather than having to write
@@ -220,7 +220,7 @@ class LLDependencies: public LLDependenciesBase
     typedef boost::function<const typename DepNode::dep_set&(const DepNode&)> dep_selector;
 
 public:
-    LLDependencies() {}
+    LLDependencies() = default;
 
     typedef KEY key_type;
     typedef NODE node_type;

indra/llcommon/lldoubledispatch.h

@@ -119,7 +119,7 @@ class LLDoubleDispatch
     typedef LLDoubleDispatch<ReturnType, ParamBaseType> self_type;
 
 public:
-    LLDoubleDispatch() {}
+    LLDoubleDispatch() = default;
 
     /**
      * Call the first matching entry.  If there's no registered Functor