Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
XDG Integration
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Silent mode is enabled
All outbound communications are blocked.
Learn more
.
Show more breadcrumbs
JennaHuntsman
XDG Integration
Commits
dde251bd
Commit
dde251bd
authored
2 years ago
by
Rye Mutt
Browse files
Options
Downloads
Patches
Plain Diff
Fix mac dsym generation when crash reporting enabled
parent
800ef77b
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
indra/cmake/DiscordSDK.cmake
+1
-10
1 addition, 10 deletions
indra/cmake/DiscordSDK.cmake
indra/cmake/Sentry.cmake
+3
-21
3 additions, 21 deletions
indra/cmake/Sentry.cmake
indra/cmake/Variables.cmake
+37
-0
37 additions, 0 deletions
indra/cmake/Variables.cmake
with
41 additions
and
31 deletions
indra/cmake/DiscordSDK.cmake
+
1
−
10
View file @
dde251bd
# -*- cmake -*-
include
(
Linking
)
include
(
Prebuilt
)
if
(
INSTALL_PROPRIETARY
)
set
(
USE_DISCORD ON CACHE BOOL
"Use Discord SDK"
FORCE
)
endif
(
INSTALL_PROPRIETARY
)
include
(
Variables
)
if
(
USE_DISCORD
)
if
(
STANDALONE
)
...
...
@@ -32,12 +29,6 @@ if (USE_DISCORD)
add_definitions
(
-DUSE_DISCORD=1
)
endif
(
STANDALONE
)
if
(
DEFINED ENV{DISCORD_CLIENTID}
)
set
(
DISCORD_CLIENTID $ENV{DISCORD_CLIENTID} CACHE STRING
"Discord Client ID"
FORCE
)
else
()
set
(
DISCORD_CLIENTID
""
CACHE STRING
"Discord Client ID"
)
endif
()
if
(
DISCORD_CLIENTID STREQUAL
""
)
message
(
FATAL_ERROR
"You must set a ClientID with -DDISCORD_CLIENTID= to enable Discord integration"
)
endif
()
...
...
This diff is collapsed.
Click to expand it.
indra/cmake/Sentry.cmake
+
3
−
21
View file @
dde251bd
# -*- cmake -*-
include
(
Linking
)
include
(
Prebuilt
)
include
(
Variables
)
#Crash reporting
option
(
USE_SENTRY
"Use the Sentry crash reporting system"
OFF
)
if
(
DEFINED ENV{USE_SENTRY}
)
set
(
USE_SENTRY $ENV{USE_SENTRY} CACHE BOOL
""
FORCE
)
endif
()
if
(
DEFINED ENV{SENTRY_DSN}
)
set
(
SENTRY_DSN $ENV{SENTRY_DSN} CACHE STRING
"Sentry DSN"
FORCE
)
endif
()
if
(
INSTALL_PROPRIETARY
)
# Note that viewer_manifest.py makes decision based on SENTRY_DSN and not USE_SENTRY
if
(
SENTRY_DSN
)
set
(
USE_SENTRY ON CACHE BOOL
"Use the Sentry crash reporting system"
FORCE
)
else
(
SENTRY_DSN
)
set
(
USE_SENTRY OFF CACHE BOOL
"Use the Sentry crash reporting system"
FORCE
)
endif
(
SENTRY_DSN
)
else
(
INSTALL_PROPRIETARY
)
set
(
USE_SENTRY OFF CACHE BOOL
"Use the Sentry crash reporting system"
FORCE
)
endif
(
INSTALL_PROPRIETARY
)
if
(
USE_SENTRY
)
if
(
NOT USESYSTEMLIBS
)
include
(
Prebuilt
)
...
...
This diff is collapsed.
Click to expand it.
indra/cmake/Variables.cmake
+
37
−
0
View file @
dde251bd
...
...
@@ -57,6 +57,43 @@ if (DEFINED ENV{USE_DISCORD})
set
(
USE_DISCORD $ENV{USE_DISCORD} CACHE BOOL
""
FORCE
)
endif
()
if
(
DEFINED ENV{DISCORD_CLIENTID}
)
set
(
DISCORD_CLIENTID $ENV{DISCORD_CLIENTID} CACHE STRING
"Discord Client ID"
FORCE
)
else
()
set
(
DISCORD_CLIENTID
""
CACHE STRING
"Discord Client ID"
)
endif
()
if
(
INSTALL_PROPRIETARY
)
set
(
USE_DISCORD ON CACHE BOOL
"Use Discord SDK"
FORCE
)
# Note that viewer_manifest.py makes decision based on SENTRY_DSN and not USE_SENTRY
if
(
DISCORD_CLIENTID
)
set
(
USE_DISCORD ON CACHE BOOL
"Use Discord SDK"
FORCE
)
else
()
set
(
USE_DISCORD OFF CACHE BOOL
"Use Discord SDK"
FORCE
)
endif
()
endif
()
#Crash reporting
option
(
USE_SENTRY
"Use the Sentry crash reporting system"
OFF
)
if
(
DEFINED ENV{USE_SENTRY}
)
set
(
USE_SENTRY $ENV{USE_SENTRY} CACHE BOOL
""
FORCE
)
endif
()
if
(
DEFINED ENV{SENTRY_DSN}
)
set
(
SENTRY_DSN $ENV{SENTRY_DSN} CACHE STRING
"Sentry DSN"
FORCE
)
endif
()
if
(
INSTALL_PROPRIETARY
)
# Note that viewer_manifest.py makes decision based on SENTRY_DSN and not USE_SENTRY
if
(
SENTRY_DSN
)
set
(
USE_SENTRY ON CACHE BOOL
"Use the Sentry crash reporting system"
FORCE
)
else
()
set
(
USE_SENTRY OFF CACHE BOOL
"Use the Sentry crash reporting system"
FORCE
)
endif
()
else
()
set
(
USE_SENTRY OFF CACHE BOOL
"Use the Sentry crash reporting system"
FORCE
)
endif
()
if
(
LIBS_CLOSED_DIR
)
file
(
TO_CMAKE_PATH
"
${
LIBS_CLOSED_DIR
}
"
LIBS_CLOSED_DIR
)
else
(
LIBS_CLOSED_DIR
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment