Skip to content
Snippets Groups Projects
Commit ecb938c9 authored by Nat Goodspeed's avatar Nat Goodspeed
Browse files

SL-18837: Try waiting a couple seconds before hdiutil detach

to try to avoid "Resource busy" errors from hdiutil.
parent dcb14036
No related branches found
No related tags found
2 merge requests!3Update to main branch,!2Rebase onto current main branch
...@@ -1329,6 +1329,10 @@ def package_finish(self): ...@@ -1329,6 +1329,10 @@ def package_finish(self):
self.run_command([self.src_path_of("installers/darwin/apple-notarize.sh"), app_in_dmg]) self.run_command([self.src_path_of("installers/darwin/apple-notarize.sh"), app_in_dmg])
finally: finally:
# Empirically, on GitHub we've hit errors like:
# hdiutil: couldn't eject "disk10" - Resource busy
# Try waiting a bit to see if that improves reliability.
time.sleep(2)
# Unmount the image even if exceptions from any of the above # Unmount the image even if exceptions from any of the above
self.run_command(['hdiutil', 'detach', '-force', devfile]) self.run_command(['hdiutil', 'detach', '-force', devfile])
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment