Skip to content
  • Nat Goodspeed's avatar
    DRTVWR-476, SL-13555: Don't crash if user closes viewer during login. · 87da08b1
    Nat Goodspeed authored
    Ever since February 2010, the body of the login coroutine function has been
    enclosed in try/catch (...), with an llerrs message to try to crash more
    informatively than the runtime's unhandled-exception termination. Over the
    years this evolved to LL_ERRS and then to CRASH_ON_UNHANDLED_EXCEPTION.
    
    This persisted despite the August 2016 addition of generic catch clauses in
    the LLCoros::toplevel() function to serve the same purpose, and despite the
    subsequent introduction of the LLCoros::Stop family of exceptions to
    deliberately throw into waiting coroutines on viewer shutdown.
    
    That's exactly what was happening. When the user closed the viewer while
    waiting for the response from login.cgi, the waiting operation threw
    LLCoros::Stopping, which was caught by that CRASH_ON_UNHANDLED_EXCEPTION,
    which crashed the viewer with LL_ERRS rather than propagating up to the
    toplevel() and cleanly terminating the coroutine.
    
    Change CRASH_ON_UNHANDLED_EXCEPTION() to LOG_UNHANDLED_EXCEPTION() and
    re-throw so toplevel() can handle.
    87da08b1