Skip to content
Snippets Groups Projects
Forked from NiranV / Black Dragon Viewer
Source project has a limited visibility.
  • Nat Goodspeed's avatar
    2a56ab44
    DRTVWR-476, SL-12197: Don't throw Stopping from main coroutine. · 2a56ab44
    Nat Goodspeed authored
    The new LLCoros::Stop exception is intended to terminate long-lived coroutines
    -- not interrupt mainstream shutdown processing. Only throw it on an
    explicitly-launched coroutine.
    
    Make LLCoros::getName() (used by the above test) static. As with other LLCoros
    methods, it might be called after the LLCoros LLSingleton instance has been
    deleted. Requiring the caller to call instance() implies a possible need to
    also call wasDeleted(). Encapsulate that nuance into a static method instead.
    2a56ab44
    History
    DRTVWR-476, SL-12197: Don't throw Stopping from main coroutine.
    Nat Goodspeed authored
    The new LLCoros::Stop exception is intended to terminate long-lived coroutines
    -- not interrupt mainstream shutdown processing. Only throw it on an
    explicitly-launched coroutine.
    
    Make LLCoros::getName() (used by the above test) static. As with other LLCoros
    methods, it might be called after the LLCoros LLSingleton instance has been
    deleted. Requiring the caller to call instance() implies a possible need to
    also call wasDeleted(). Encapsulate that nuance into a static method instead.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.