- Jun 30, 2016
-
-
Nat Goodspeed authored
The LLApp API used to consist of init(), mainLoop(), cleanup() methods. This makes sense -- but on Mac that structure was being subverted. The method called mainLoop() was in fact being called once per frame. There was initialization code in the method, which (on Mac) needed to be skipped with an already-initialized bool. There was a 'while' loop which (on Mac) needed to be turned into an 'if' instead so the method would return after every frame. Rename LLApp::mainLoop() to frame(). Propagate through subclasses LLAppViewer and LLCrashLogger. Document the fact that frame() returns true to mean "done." (This was always the case, but had to be inferred from the code.) Rename the Mac Objective-C function mainLoop to oneFrame. Rename the C++ free function it calls from runMainLoop() to pumpMainLoop(). Add comments to llappdelegate-objc.mm explaining (inferred) control flow. Change the Linux viewer main() and the Windows viewer WINMAIN() from a single LLAppViewer::mainLoop() call to repeatedly call frame() until it returns true. Move initialization code from the top of LLAppViewer::frame() to the init() method, where it more properly belongs. Remove corresponding mMainLoopInitialized flag (and all references) from LLAppViewer. Remove 'while (! LLApp::isExiting())' (or on Mac, 'if (! LLApp::isExiting())') from LLAppViewer::frame() -- thus unindenting the whole body of the 'while' and causing many lines of apparent change. (Apologies to reviewers.) There are four LLApp states: APP_STATUS_RUNNING, APP_STATUS_QUITTING, APP_STATUS_STOPPED and APP_STATUS_ERROR. Change LLAppViewer::frame() return value from (isExiting()) (QUITTING or ERROR) to (! isRunning()). I do not know under what circumstances the state might transition to STOPPED during a frame() call, but I'm quite sure that if it does, we don't want to call frame() again. We only want a subsequent call if the state is RUNNING. Also rename mainLoop() method in LLCrashLogger subclasses LLCrashLoggerWindows, LLCrashLoggerMac, LLCrashLoggerLinux. Of course it's completely up to the frame() method whether to yield control; none of those in fact do. Honor protocol by returning true (frame() is done), even though each one's main() caller ignores the return value. In fact LLCrashLoggerWindows::mainLoop() wasn't using the return protocol correctly anyway, returning wParam or 0 or 1 -- possibly because the return protocol was never explicitly documented. It should always return true: "I'm done, don't call me again."
-
- May 19, 2016
- May 10, 2016
-
-
Oz Linden authored
-
- May 09, 2016
-
-
Rider Linden authored
MAINT-6392: Do not change the URL used for getting cookies (except to pass it to CEF) The original URL is used for HTTP Core access to profile functionality.
-
- May 07, 2016
-
-
Oz Linden authored
-
- May 06, 2016
- May 05, 2016
-
-
Oz Linden authored
-
- May 04, 2016
- May 02, 2016
-
-
Ansariel authored
-
Ansariel Hiller authored
-
- Apr 29, 2016
- Apr 28, 2016
- Apr 26, 2016
-
-
Rider Linden authored
-
Rider Linden authored
-
Rider Linden authored
MAINT-6336: Put the timeout upstream of the suspending pump and fire the timeout it. Also some cleanup on LLSD construction in vivox.
-
Oz Linden authored
-
Oz Linden authored
-
- Apr 25, 2016
-
-
Rider Linden authored
-
Rider Linden authored
MAINT-6338: Add methods for getting and setting boolean properties from gSavedSettings in the HTTPCore. Use those methods to access new key HTTPLogBodyOnError. Dump body of HTTP message to log in case of error if this key is true.
-
- Apr 22, 2016
-
-
Rider Linden authored
-
Rider Linden authored
-
Rider Linden authored
MAINT-6336: Centralize waiting on event pump with a timeout. Shorten the lifespan of a timeout event pump lifespan to be no longer than necessary. Change all references to the LLEventTimer to instead uses the centralized version.
-
Oz Linden authored
-
- Apr 21, 2016
-
-
Andrey Lihatskiy authored
-
AndreyL ProductEngine authored
-
Oz Linden authored
Fix further merge error in LLLiveLSLEditor::draw()
-
Oz Linden authored
-
ruslantproductengine authored
MAINT-6326 [QuickGraphics-RC] Blingposter avatars are all full bright white when basic shaders are disabled.
-
Rider Linden authored
-
Oz Linden authored
MAINT-6317 [QuickGraphics-RC] Some rigged mesh attachments render fully on jellybaby avatars when ALM is enabled
-