Skip to content
Snippets Groups Projects
Forked from Alchemy Viewer / Alchemy Viewer
Source project has a limited visibility.
  • Nat Goodspeed's avatar
    04ebc11a
    SL-16094: Fix WorkQueue test for correct behavior of runFor(). · 04ebc11a
    Nat Goodspeed authored
    Turns out that one of our WorkQueue integration tests was relying on the
    incorrect runFor() behavior that we just fixed, so the test broke. Now that
    runFor() doesn't wait around for work to be posted, use an explicit wait loop
    instead.
    
    To support this, add LLCond::get(functor), where functor must accept a const
    reference to the stored data. This new get() returns whatever the functor
    returns, allowing a caller to peek at the stored data.
    
    Also use universal references for all remaining LLCond functor arguments.
    04ebc11a
    History
    SL-16094: Fix WorkQueue test for correct behavior of runFor().
    Nat Goodspeed authored
    Turns out that one of our WorkQueue integration tests was relying on the
    incorrect runFor() behavior that we just fixed, so the test broke. Now that
    runFor() doesn't wait around for work to be posted, use an explicit wait loop
    instead.
    
    To support this, add LLCond::get(functor), where functor must accept a const
    reference to the stored data. This new get() returns whatever the functor
    returns, allowing a caller to peek at the stored data.
    
    Also use universal references for all remaining LLCond functor arguments.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.