Henri Beauchamp authored 1 year ago and Rye Mutt committed 1 year ago

This PR fixes the non-working material hashing for LLGLTFMaterial instances.

There are several issues in the current code, stemming to the fact that the hashing is performed on the block of the member variables:

1.- There are padding bytes between member variables, even after rearranging them to avoid most of the padding; in particular, the std::array's size is not a multiple of 4 bytes (64 bits), and most compilers will pad them to the next 4-byte aligment as a result. Note that C++ standards do not impose the zeroing of padding bytes on construction of a class instance, with only a couple exceptions (such as explicit zero-initialization). Those bytes MUST therefore be zeroed by us on construction.
2.- The TextureTransform strutcure getPacked() method did not touch some of the packed bytes, and as a result could *potentially* cause an issue for hashing when applied to a transform of another material instance.
3.- With the recent addition of the local textures tracking map, the said map cannot be hashed as a block of memory (map pairs will typically be allocated on the heap or on the stack, not in the memory block used by member variables).

This PR solves all these issues and offers proper hashing of LLGLTFMaterial instances.

* SL-20570 Fix for lossy (and square) normal maps when importing GLTF materials.

* SL-20582 Fix for overriding to alpha mode blend not working.  Incidental decruft of dead code (thanks, Rye!)

SL-20582 Fix for overriding to alpha mode blend not working.  Incidental decruft of dead code (thanks, Rye!)

Update editor in which texture changed to local

SL-19564 Rebalance exposure and sky.  Hack legacy diffuse map saturation and brightness to allow ACES Hill all the time.

* SL-19538 Remove hacky ambiance scale and take the mittens off probe ambiance values.  Fix for sky brightening being done in sRGB space.

Miezhiko authored 1 year ago and Rye Mutt committed 1 year ago

Signed-off-by: Miezhiko <Miezhiko@gmail.com>