Merged with default tip (Revision c752f2cb29e1)

--HG--
branch : Appearance-MixedViewers

.hgpatchinfo/Appearance-MixedViewers.dep

+d2e09cac94057f89e59295dc83b7c17abb8380a5
\ No newline at end of file

.hgpatchinfo/Appearance-MixedViewers.desc

+[Appearance/MixedViewers]
+- fixed : "Worn items in Viewer 2 and Viewer 1.x aren't synchronized" (http://jira.secondlife.com/browse/VWR-17594)
+    -> current fix compares *only* the wearables in COF with the wearables specified by AgentWearablesUpdate
+- fixed : minor memory leak in LLInitialWearablesFetch::processWearablesMessage()

indra/newview/llagentwearablesfetch.cpp

@@ -119,8 +119,42 @@ void LLInitialWearablesFetch::processContents()
 	gInventory.collectDescendentsIf(mComplete.front(), cat_array, wearable_array, 
 									LLInventoryModel::EXCLUDE_TRASH, is_wearable);
 
+// [SL:KB] - Patch: Appearance-MixedViewers | Checked: 2010-05-18 (Catznip-2.1.2a) | Modified: Catznip-2.0.0h
+	// NOTE: don't use the current COF contents if 'wearable_array' is empty (ie first logon with 2.0 or some other problem)
+	bool fUpdateFromCOF = !wearable_array.empty();
+	if (fUpdateFromCOF)
+	{
+		LLAppearanceMgr::wearables_by_type_t items_by_type(LLWearableType::WT_COUNT);
+		LLAppearanceMgr::sortItemsByActualDescription(wearable_array);
+		LLAppearanceMgr::divvyWearablesByType(wearable_array, items_by_type);
+
+		// Compare the COF wearables against the initial wearables
+		for (initial_wearable_data_vec_t::const_iterator itWearableData = mAgentInitialWearables.begin();
+				(itWearableData != mAgentInitialWearables.end()) && (fUpdateFromCOF);  ++itWearableData)
+		{
+			const LLUUID& idItem = itWearableData->mItemID; bool fFound = false;
+
+			// TODO-Catznip: [SL-2.1.0] Bit of a hack until LL supports changing the descriptions of links
+			for (S32 idxItem = 0, cntItem = items_by_type[itWearableData->mType].size(); idxItem < cntItem; idxItem++)
+			{
+				const LLViewerInventoryItem* pCOFItem = items_by_type[itWearableData->mType].get(idxItem);
+				if (idItem == pCOFItem->getLinkedUUID())
+				{
+					fFound = true;
+					break;
+				}
+			}
+			if (!fFound)
+				fUpdateFromCOF = false;
+		}
+	}
+// [/SL:KB]
+
 	LLAppearanceMgr::instance().setAttachmentInvLinkEnable(true);
-	if (wearable_array.count() > 0)
+//	if (wearable_array.count() > 0)
+// [SL:KB] - Patch: Appearance-MixedViewers | Checked: 2010-04-28 (Catznip-2.1.2a) | Modified: Catznip-2.0.0e
+	if (fUpdateFromCOF)
+// [/SL:KB]
 	{
 		gAgentWearables.notifyLoadingStarted();
 		LLAppearanceMgr::instance().updateAppearanceFromCOF();
@@ -147,7 +181,7 @@ public:
 	virtual void done()
 	{
 		gInventory.removeObserver(this);
-
+/*
 		// Link to all fetched items in COF.
 		LLPointer<LLInventoryCallback> link_waiter = new LLUpdateAppearanceOnDestroy;
 		for (uuid_vec_t::iterator it = mIDs.begin();
@@ -170,7 +204,33 @@ public:
 								LLAssetType::AT_LINK,
 								link_waiter);
 		}
+*/
+// [SL:KB] - Patch: Appearance-MixedViewers | Checked: 2010-08-14 (Catznip-2.1.2a) | Added: Catznip-2.1.1d
+		doOnIdleOneTime(boost::bind(&LLFetchAndLinkObserver::doneIdle, this));
+// [/SL:KB]
+	}
+
+// [SL:KB] - Patch: Appearance-MixedViewers | Checked: 2010-04-02 (Catznip-2.1.2a) | Added: Catznip-2.0.0a
+	void doneIdle()
+	{
+		// NOTE: the code above makes the assumption that COF is empty which won't be the case the way it's used now
+		LLInventoryModel::item_array_t initial_items;
+		for (uuid_vec_t::iterator itItem = mIDs.begin(); itItem != mIDs.end(); ++itItem)
+		{
+			LLViewerInventoryItem* pItem = gInventory.getItem(*itItem);
+			if (!pItem)
+			{
+				llwarns << "fetch failed!" << llendl;
+				continue;
+			}
+			initial_items.push_back(pItem);
+		}
+
+		LLAppearanceMgr::instance().updateAppearanceFromInitialWearables(initial_items);
+
+		delete this;
 	}
+// [/SL:KB]
 };
 
 void LLInitialWearablesFetch::processWearablesMessage()
@@ -182,7 +242,11 @@ void LLInitialWearablesFetch::processWearablesMessage()
 		for (U8 i = 0; i < mAgentInitialWearables.size(); ++i)
 		{
 			// Populate the current outfit folder with links to the wearables passed in the message
-			InitialWearableData *wearable_data = new InitialWearableData(mAgentInitialWearables[i]); // This will be deleted in the callback.
+//			InitialWearableData *wearable_data = new InitialWearableData(mAgentInitialWearables[i]); // This will be deleted in the callback.
+// [SL:KB] - Patch: Appearance-MixedViewers | Checked: 2010-05-02 (Catznip-2.1.2a) | Added: Catznip-2.0.0f
+			// Fixes minor leak: since COF is used onInitialWearableAssetArrived() will never get called and "wearable_data" leaks
+			InitialWearableData* wearable_data = &mAgentInitialWearables[i];
+// [/SL:KB]
 			
 			if (wearable_data->mAssetID.notNull())
 			{
@@ -192,7 +256,7 @@ void LLInitialWearablesFetch::processWearablesMessage()
 			{
 				llinfos << "Invalid wearable, type " << wearable_data->mType << " itemID "
 				<< wearable_data->mItemID << " assetID " << wearable_data->mAssetID << llendl;
-				delete wearable_data;
+//				delete wearable_data;
 			}
 		}
 

indra/newview/llappearancemgr.cpp

@@ -1773,6 +1773,21 @@ void LLAppearanceMgr::updateAppearanceFromCOF(bool update_base_outfit_ordering)
 	}
 }
 
+// [SL:KB] - Patch: Appearance-MixedViewers | Checked: 2010-04-02 (Catznip-2.1.2a) | Added: Catznip-2.0.0a
+void LLAppearanceMgr::updateAppearanceFromInitialWearables(LLInventoryModel::item_array_t& initial_items)
+{
+	const LLUUID& idCOF = getCOF();
+
+	// Remove current COF contents
+	purgeCategory(idCOF, false);
+	gInventory.notifyObservers();
+
+	// Create links to new COF contents
+	LLPointer<LLInventoryCallback> link_waiter = new LLUpdateAppearanceOnDestroy;
+	linkAll(idCOF, initial_items, link_waiter);
+}
+// [/SL:KB]
+
 void LLAppearanceMgr::getDescendentsOfAssetType(const LLUUID& category,
 													LLInventoryModel::item_array_t& items,
 													LLAssetType::EType type,

indra/newview/llappearancemgr.h

@@ -51,6 +51,9 @@ public:
 	typedef std::vector<LLInventoryModel::item_array_t> wearables_by_type_t;
 
 	void updateAppearanceFromCOF(bool update_base_outfit_ordering = false);
+// [SL:KB] - Patch: Appearance-MixedViewers | Checked: 2010-04-02 (Catznip-2.1.2a) | Added: Catznip-2.0.0a
+	void updateAppearanceFromInitialWearables(LLInventoryModel::item_array_t& initial_items);
+// [/SL:KB]
 	bool needToSaveCOF();
 	void updateCOF(const LLUUID& category, bool append = false);
 	void wearInventoryCategory(LLInventoryCategory* category, bool copy, bool append);