Skip to content
Snippets Groups Projects
  1. Jul 10, 2017
  2. Jun 29, 2017
  3. Jun 28, 2017
  4. Jun 27, 2017
  5. Jun 26, 2017
    • Glenn Glazer's avatar
      263a9e77
    • Glenn Glazer's avatar
      merge · 1c148b5b
      Glenn Glazer authored
      1c148b5b
    • Nat Goodspeed's avatar
    • Nat Goodspeed's avatar
    • Glenn Glazer's avatar
      upgrade to VMP package 506854 · 74afc93a
      Glenn Glazer authored
      74afc93a
    • Nat Goodspeed's avatar
    • Nat Goodspeed's avatar
      MAINT-7514: Add (32) or (64) to registry for "install again?" prompt. · b3c506bc
      Nat Goodspeed authored
      Specifically, append (32) or (64) to the four-part version number stored in
      the registry entry used to detect whether this viewer has already been
      installed. This is injected as a new VERSION_REGISTRY NSIS variable.
      
      (It was tempting to simply change the value of VERSION_LONG with the embedded
      address size. However, there is one other use of VERSION_LONG in the NSIS
      template. That use is the subject of MAINT-7533.)
      
      Synthesize the VERSION_REGISTRY value in viewer_manifest.py and add it to the
      substitution dict used to populate the NSIS template.
      
      ADDRESS_SIZE isn't passed into viewer_manifest.py, but it can be inferred from
      the existing 'arch' parameter: 'arch' as well as 'platform' is used to select
      the specific subclass of the ViewerManifest class to instantiate for this run.
      Add an appropriate address_size attribute to every such subclass.
      
      Change a couple existing tests on 'arch' to tests on self.address_size instead
      -- clearer to the maintainer.
      
      Also, given that subclass selection mechanism, the ViewerManifest base class
      shouldn't need if / elif tests on 'platform'. Make build_data_json_platform a
      class attribute as well, removing the base-class stanza that dynamically
      examines 'platform' and 'arch'.
      
      Similarly, move platform-specific tweaks to the build_data_dict used to
      populate build_data.json into a new finish_build_data_dict() method overridden
      by individual platform subclasses.
      
      Encapsulate the logic around running the Windows code-signing tool into a
      sign() method, and call it as needed. For obtaining environment variables with
      fallback values, use os.environ.get() instead of os.path.expandvars() with
      tests on the returned value.
      b3c506bc
  6. Jun 23, 2017
  7. Jun 22, 2017
  8. Jun 21, 2017
  9. Jun 20, 2017
  10. Jun 19, 2017
  11. Jun 16, 2017
  12. Jun 15, 2017
  13. Jun 14, 2017
  14. Jun 13, 2017
Loading