Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    0ea1b2a1
    MAINT-5232: Try to avoid circularity between LLError and LLSingleton. · 0ea1b2a1
    Nat Goodspeed authored
    Part of LLError's logging infrastructure is implemented with an LLSingleton.
    Therefore, attempts to log from within LLSingleton machinery could potentially
    go south if LLError's LLSingleton is not yet initialized.
    Introduce LLError::is_available() in llerrorcontrol.h and llerror.cpp.
    Make LLSingletonBase::logwarns() and logerrs() consult LLError::is_available()
    before attempting to use LL_WARNS or LL_ERRS, respectively.
    Moreover, make all LLSingleton internal logging use logwarns() and logerrs()
    instead of directly engaging LL_ERRS or LL_WARNS.
    0ea1b2a1
    History
    MAINT-5232: Try to avoid circularity between LLError and LLSingleton.
    Nat Goodspeed authored
    Part of LLError's logging infrastructure is implemented with an LLSingleton.
    Therefore, attempts to log from within LLSingleton machinery could potentially
    go south if LLError's LLSingleton is not yet initialized.
    Introduce LLError::is_available() in llerrorcontrol.h and llerror.cpp.
    Make LLSingletonBase::logwarns() and logerrs() consult LLError::is_available()
    before attempting to use LL_WARNS or LL_ERRS, respectively.
    Moreover, make all LLSingleton internal logging use logwarns() and logerrs()
    instead of directly engaging LL_ERRS or LL_WARNS.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.