Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    2bb19aec
    DRTVWR-418, MAINT-6996: Update Mac LLMemory::getCurrentRSS(). · 2bb19aec
    Nat Goodspeed authored
    Evidently the Mac implementation of LLMemory::getCurrentRSS() goes back to
    OS X 10.3, because there was a helpful comment of the form:
    
    ------
    The API used here is not capable of dealing with 64-bit memory sizes, but is
    available before 10.4.
    
    Once we start requiring 10.4, we can use the updated API, which looks like
    this:
    
    [new current implementation]
    
    Of course, this doesn't gain us anything unless we start building the viewer
    as a 64-bit executable, since that's the only way for our memory allocation to
    exceed 2^32.
    ------
    
    Hey, guess what, we're building 64-bit viewers now!
    
    Thank you, whoever thoughtfully noted that, both for calling out the issue and
    sparing us the research. (The comment goes back to Subversion days, so hg
    blame shows only the merge-to-release changeset.)
    2bb19aec
    History
    DRTVWR-418, MAINT-6996: Update Mac LLMemory::getCurrentRSS().
    Nat Goodspeed authored
    Evidently the Mac implementation of LLMemory::getCurrentRSS() goes back to
    OS X 10.3, because there was a helpful comment of the form:
    
    ------
    The API used here is not capable of dealing with 64-bit memory sizes, but is
    available before 10.4.
    
    Once we start requiring 10.4, we can use the updated API, which looks like
    this:
    
    [new current implementation]
    
    Of course, this doesn't gain us anything unless we start building the viewer
    as a 64-bit executable, since that's the only way for our memory allocation to
    exceed 2^32.
    ------
    
    Hey, guess what, we're building 64-bit viewers now!
    
    Thank you, whoever thoughtfully noted that, both for calling out the issue and
    sparing us the research. (The comment goes back to Subversion days, so hg
    blame shows only the merge-to-release changeset.)
Code owners
Assign users and groups as approvers for specific file changes. Learn more.