Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    3e66dc9f
    MAINT-8822: Revert viewer_manifest to using src= instead of build=. · 3e66dc9f
    Nat Goodspeed authored
    Turns out that having multiple (source, build, artwork) prefix stacks isn't
    such a good idea after all. Many of our LLManifest.path() directives use
    wildcards -- and if _any files_ match the specified wildcard from a prefix
    stack other than what you had in mind, viewer_manifest will silently,
    cheerfully do the Wrong Thing.
    
    There is a good reason why all existing LLManifest.prefix() calls exclusively
    used src= and/or dst= instead of build=.
    3e66dc9f
    History
    MAINT-8822: Revert viewer_manifest to using src= instead of build=.
    Nat Goodspeed authored
    Turns out that having multiple (source, build, artwork) prefix stacks isn't
    such a good idea after all. Many of our LLManifest.path() directives use
    wildcards -- and if _any files_ match the specified wildcard from a prefix
    stack other than what you had in mind, viewer_manifest will silently,
    cheerfully do the Wrong Thing.
    
    There is a good reason why all existing LLManifest.prefix() calls exclusively
    used src= and/or dst= instead of build=.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.