Skip to content
Snippets Groups Projects
  • Martin Reddy's avatar
    47abd559
    EXT-944 EXT-1026: reverting my previous fix for these crashes. · 47abd559
    Martin Reddy authored
    This didn't work on Windows because wchar_t is 2 bytes on that
    platform, not 4 bytes (whereas llwchar is 4 bytes everywhere).
    Boost's regex methods need to work on wchar_t, but I believe
    that using a UTF-16 string would still be prone to crashing on
    Windows as UTF-16 is still a variable-length encoding. Besides,
    trying to compile a UTF-16 solution generates weird link errors.
    
    Instead, I'm going to fix this problem a different way. And
    I'm starting by reverting the previous attempt. Thanks Win32.
    47abd559
    History
    EXT-944 EXT-1026: reverting my previous fix for these crashes.
    Martin Reddy authored
    This didn't work on Windows because wchar_t is 2 bytes on that
    platform, not 4 bytes (whereas llwchar is 4 bytes everywhere).
    Boost's regex methods need to work on wchar_t, but I believe
    that using a UTF-16 string would still be prone to crashing on
    Windows as UTF-16 is still a variable-length encoding. Besides,
    trying to compile a UTF-16 solution generates weird link errors.
    
    Instead, I'm going to fix this problem a different way. And
    I'm starting by reverting the previous attempt. Thanks Win32.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.