Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    49cfd6d9
    DRTVWR-418, MAINT-6996: On Mac, obtain total mem, not resident mem. · 49cfd6d9
    Nat Goodspeed authored
    The LLMemory method getCurrentRSS() is defined to return the "resident set
    size," but in fact on Windows it returns the WorkingSetSize -- and that's
    actually what callers want from it: the total memory consumed by the
    application for statistics purposes. It's not really clear what users gain by
    knowing how much of that is resident in real memory, versus the total
    consumption. So despite the commentation and the method name itself, on Mac
    make it return the virtual size consumed.
    49cfd6d9
    History
    DRTVWR-418, MAINT-6996: On Mac, obtain total mem, not resident mem.
    Nat Goodspeed authored
    The LLMemory method getCurrentRSS() is defined to return the "resident set
    size," but in fact on Windows it returns the WorkingSetSize -- and that's
    actually what callers want from it: the total memory consumed by the
    application for statistics purposes. It's not really clear what users gain by
    knowing how much of that is resident in real memory, versus the total
    consumption. So despite the commentation and the method name itself, on Mac
    make it return the virtual size consumed.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.