Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    6805e82a
    DRTVWR-476: Introduce LLEventMailDrop::discard() (instead of flush()). · 6805e82a
    Nat Goodspeed authored
    Overriding virtual LLEventPump::flush() for the semantic of discarding
    LLEventMailDrop's queued events turns out not to be such a great idea, because
    LLEventPumps::flush(), which calls every registered LLEventPump's flush()
    method, is called every mainloop tick. The first time we hit a use case in
    which we expected LLEventMailDrop to hold queued events across a mainloop tick,
    we were baffled that they were never delivered.
    
    Moving that logic to a separate method specific to LLEventMailDrop resolves
    that problem. Naming it discard() clarifies its intended functionality.
    6805e82a
    History
    DRTVWR-476: Introduce LLEventMailDrop::discard() (instead of flush()).
    Nat Goodspeed authored
    Overriding virtual LLEventPump::flush() for the semantic of discarding
    LLEventMailDrop's queued events turns out not to be such a great idea, because
    LLEventPumps::flush(), which calls every registered LLEventPump's flush()
    method, is called every mainloop tick. The first time we hit a use case in
    which we expected LLEventMailDrop to hold queued events across a mainloop tick,
    we were baffled that they were never delivered.
    
    Moving that logic to a separate method specific to LLEventMailDrop resolves
    that problem. Naming it discard() clarifies its intended functionality.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.