Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    75f41254
    Break large buffer into chunks to write to LLProcess child pipe. · 75f41254
    Nat Goodspeed authored
    On Windows we ran into trouble trying to write a biggish (~1 MB) buffer of
    data to the child process's stdin pipe with a single apr_file_write() call.
    The child actually received corrupted data -- suggesting a possible bug in
    either APR or Windows pipes; the same test driving the same logic worked fine
    on Mac and Linux. Empirically, iterating over chunks of the buffered data is
    more robust.
    75f41254
    History
    Break large buffer into chunks to write to LLProcess child pipe.
    Nat Goodspeed authored
    On Windows we ran into trouble trying to write a biggish (~1 MB) buffer of
    data to the child process's stdin pipe with a single apr_file_write() call.
    The child actually received corrupted data -- suggesting a possible bug in
    either APR or Windows pipes; the same test driving the same logic worked fine
    on Mac and Linux. Empirically, iterating over chunks of the buffered data is
    more robust.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.