Skip to content
Snippets Groups Projects
  • Nicky's avatar
    84ca1a3c
    Do not bit blast 0 into a non POD struct to zero it, rather use the default constructor. · 84ca1a3c
    Nicky authored
    There is a few peculiar differences in default member initializationn namely:
    gamma > 1.0f; sun_norm > 0.0f, 1.0f, 0.0f, 1.0f; cloud_shadow > 1.0f; dome_radius > 1.0f; dome_offset > 1.0f
    Which probably made the original memset produce the wrong result anyway as it differs from the value the
    LLVOSky set (the default ctor of AtmosphericsVars) vs what the memset would produce in case of a force update (all 0s).
    84ca1a3c
    History
    Do not bit blast 0 into a non POD struct to zero it, rather use the default constructor.
    Nicky authored
    There is a few peculiar differences in default member initializationn namely:
    gamma > 1.0f; sun_norm > 0.0f, 1.0f, 0.0f, 1.0f; cloud_shadow > 1.0f; dome_radius > 1.0f; dome_offset > 1.0f
    Which probably made the original memset produce the wrong result anyway as it differs from the value the
    LLVOSky set (the default ctor of AtmosphericsVars) vs what the memset would produce in case of a force update (all 0s).
Code owners
Assign users and groups as approvers for specific file changes. Learn more.