Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    93268cb4
    DRTVWR-418: Put TYPE_INDEX within TYPE_MAX: stop undefined indexing. · 93268cb4
    Nat Goodspeed authored
    LLVertexBuffer::TYPE_INDEX was past TYPE_MAX, which is used to set the maximum
    sizes of various (scattered) arrays, bleh. The alarm bells that this SHOULD
    set off are indeed correct: TYPE_INDEX was being used to index at least one of
    those arrays, meaning we've been indexing past the end of that array, meaning
    undefined behavior.
    
    The enum that defines both TYPE_INDEX and TYPE_MAX provides a helpful comment
    indicating what things must be updated when modifying the enum. (Far better to
    define things centrally in a single place... but another time.) Update the
    designated arrays to include a final TYPE_INDEX entry. Contents of those
    entries are wild guesses -- but even wild guesses are better than completely
    indeterminate data.
    93268cb4
    History
    DRTVWR-418: Put TYPE_INDEX within TYPE_MAX: stop undefined indexing.
    Nat Goodspeed authored
    LLVertexBuffer::TYPE_INDEX was past TYPE_MAX, which is used to set the maximum
    sizes of various (scattered) arrays, bleh. The alarm bells that this SHOULD
    set off are indeed correct: TYPE_INDEX was being used to index at least one of
    those arrays, meaning we've been indexing past the end of that array, meaning
    undefined behavior.
    
    The enum that defines both TYPE_INDEX and TYPE_MAX provides a helpful comment
    indicating what things must be updated when modifying the enum. (Far better to
    define things centrally in a single place... but another time.) Update the
    designated arrays to include a final TYPE_INDEX entry. Contents of those
    entries are wild guesses -- but even wild guesses are better than completely
    indeterminate data.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.