Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    a1c69da3
    QAR-1619: Fix Windows link errors when building INTEGRATION_TEST_lllazy. · a1c69da3
    Nat Goodspeed authored
    The problem arose because we were setting LL_COMMON_BUILD in
    llcommon/CMakeLists.txt, not only for the library build itself but also for
    its LL_ADD_INTEGRATION_TEST tests. This told all the headers compiled into the
    INTEGRATION_TEST_lllazy executable that the executable was providing all the
    llcommon symbols, rather than importing them.
    The solution is to switch to the llcommon_EXPORTS symbol automagically defined
    by CMake when building the llcommon shared library itself.
    a1c69da3
    History
    QAR-1619: Fix Windows link errors when building INTEGRATION_TEST_lllazy.
    Nat Goodspeed authored
    The problem arose because we were setting LL_COMMON_BUILD in
    llcommon/CMakeLists.txt, not only for the library build itself but also for
    its LL_ADD_INTEGRATION_TEST tests. This told all the headers compiled into the
    INTEGRATION_TEST_lllazy executable that the executable was providing all the
    llcommon symbols, rather than importing them.
    The solution is to switch to the llcommon_EXPORTS symbol automagically defined
    by CMake when building the llcommon shared library itself.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.