Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    bdea9739
    MAINT-8087: Use SHGetKnownFolderPath(), not SHGetSpecialFolderPath(). · bdea9739
    Nat Goodspeed authored
    SHGetSpecialFolderPath() is deprecated, and empirically it appears to be
    failing when the user name contains non-ASCII characters. The relevant
    Microsoft documentation pages recommend calling SHGetKnownFolderPath()
    instead.
    
    Also, the SHGetSpecialFolderPath() calls had no error checking or reporting,
    which is why we can only say it "appears to be" failing. Make sure that if
    SHGetKnownFolderPath() fails, at least we try to tell somebody about it.
    bdea9739
    History
    MAINT-8087: Use SHGetKnownFolderPath(), not SHGetSpecialFolderPath().
    Nat Goodspeed authored
    SHGetSpecialFolderPath() is deprecated, and empirically it appears to be
    failing when the user name contains non-ASCII characters. The relevant
    Microsoft documentation pages recommend calling SHGetKnownFolderPath()
    instead.
    
    Also, the SHGetSpecialFolderPath() calls had no error checking or reporting,
    which is why we can only say it "appears to be" failing. Make sure that if
    SHGetKnownFolderPath() fails, at least we try to tell somebody about it.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.