Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    6bc95042
    DRTVWR-418: Rationalize LLPipeline API. · 6bc95042
    Nat Goodspeed authored
    Someone evidently figured every static LLPipeline method should have at least
    one void* parameter. There were methods requiring void* parameters that were
    completely ignored.
    
    More to the point, there were methods whose callers have a U32 in hand -- and
    which want to use a U32 -- but which bizarrely forced callers to cast to void*
    just so the method could cast back to U32. In a 64-bit compile, this isn't
    merely pointless, it's erroneous. Change all such methods to accept U32;
    remove (void*) casts from call sites.
    
    While at it, fix LLPipeline API to use bool, true, false rather than their
    obsolete all-caps predecessors. Once you eat that first potato chip... :-P
    6bc95042
    History
    DRTVWR-418: Rationalize LLPipeline API.
    Nat Goodspeed authored
    Someone evidently figured every static LLPipeline method should have at least
    one void* parameter. There were methods requiring void* parameters that were
    completely ignored.
    
    More to the point, there were methods whose callers have a U32 in hand -- and
    which want to use a U32 -- but which bizarrely forced callers to cast to void*
    just so the method could cast back to U32. In a 64-bit compile, this isn't
    merely pointless, it's erroneous. Change all such methods to accept U32;
    remove (void*) casts from call sites.
    
    While at it, fix LLPipeline API to use bool, true, false rather than their
    obsolete all-caps predecessors. Once you eat that first potato chip... :-P
Code owners
Assign users and groups as approvers for specific file changes. Learn more.