Skip to content
Snippets Groups Projects
  • Nat Goodspeed's avatar
    d1ab4705
    DRTVWR-418: Fix C++ errors detected by Xcode 9. · d1ab4705
    Nat Goodspeed authored
    You can't legitimately perform an ordered comparison between a pointer and an
    int, even 0. Fix a number of 'if (ptr > 0)' to plain 'if (ptr)'.
    
    Fix LLEditWearableDictionary::WearableEntry constructor to avoid varargs
    mechanism. It used to accept three different counts, followed by three
    different lists of enums, fetched in each case as 'int' -- dubious in itself.
    The constructor body performed three different loops to populate those enums
    into three different member vectors.
    
    Instead, make the constructor accept three vectors and initialize the member
    vectors from the passed vectors. Now that C++ has inline vector
    initialization, change existing constructor calls to pass temporary vectors
    initialized with what used to be the varargs enum values.
    d1ab4705
    History
    DRTVWR-418: Fix C++ errors detected by Xcode 9.
    Nat Goodspeed authored
    You can't legitimately perform an ordered comparison between a pointer and an
    int, even 0. Fix a number of 'if (ptr > 0)' to plain 'if (ptr)'.
    
    Fix LLEditWearableDictionary::WearableEntry constructor to avoid varargs
    mechanism. It used to accept three different counts, followed by three
    different lists of enums, fetched in each case as 'int' -- dubious in itself.
    The constructor body performed three different loops to populate those enums
    into three different member vectors.
    
    Instead, make the constructor accept three vectors and initialize the member
    vectors from the passed vectors. Now that C++ has inline vector
    initialization, change existing constructor calls to pass temporary vectors
    initialized with what used to be the varargs enum values.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.