Skip to content
Snippets Groups Projects
Commit 002bbd88 authored by Mike Antipov's avatar Mike Antipov
Browse files

EXT-8318 FIX IMPROVED converted EOLs

--HG--
branch : product-engine
parent 8e461d90
No related branches found
No related tags found
No related merge requests found
...@@ -673,9 +673,9 @@ std::string ll_convert_wide_to_string(const wchar_t* in, unsigned int code_page) ...@@ -673,9 +673,9 @@ std::string ll_convert_wide_to_string(const wchar_t* in, unsigned int code_page)
wchar_t* ll_convert_string_to_wide(const std::string& in, unsigned int code_page) wchar_t* ll_convert_string_to_wide(const std::string& in, unsigned int code_page)
{ {
// From review: // From review:
// We can preallocate a wide char buffer that is the same length (in wchar_t elements) as the utf8 input, // We can preallocate a wide char buffer that is the same length (in wchar_t elements) as the utf8 input,
// plus one for a null terminator, and be guaranteed to not overflow. // plus one for a null terminator, and be guaranteed to not overflow.
// Normally, I'd call that sort of thing premature optimization, // Normally, I'd call that sort of thing premature optimization,
// but we *are* seeing string operations taking a bunch of time, especially when constructing widgets. // but we *are* seeing string operations taking a bunch of time, especially when constructing widgets.
// int output_str_len = MultiByteToWideChar(code_page, 0, in.c_str(), in.length(), NULL, 0); // int output_str_len = MultiByteToWideChar(code_page, 0, in.c_str(), in.length(), NULL, 0);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment