Skip to content
Snippets Groups Projects
Commit 07d7e48f authored by Nat Goodspeed's avatar Nat Goodspeed
Browse files

DRTVWR-447: Use absolute path prefixes for CEF components.

viewer_manifest.py had LLManifest.prefix() calls starting with '..' (or
os.pardir, same thing) which failed with new prefix() calling conventions.
Explicitly starting with os.path.join(self.args['build'], os.pardir, etc.)
where applicable works much better.
parent 20907dbb
No related branches found
No related tags found
No related merge requests found
...@@ -221,8 +221,7 @@ def channel_variant(self): ...@@ -221,8 +221,7 @@ def channel_variant(self):
return self.channel().replace(CHANNEL_VENDOR_BASE, "").strip() return self.channel().replace(CHANNEL_VENDOR_BASE, "").strip()
def channel_type(self): # returns 'release', 'beta', 'project', or 'test' def channel_type(self): # returns 'release', 'beta', 'project', or 'test'
global CHANNEL_VENDOR_BASE channel_qualifier=self.channel_variant().lower()
channel_qualifier=self.channel().replace(CHANNEL_VENDOR_BASE, "").lower().strip()
if channel_qualifier.startswith('release'): if channel_qualifier.startswith('release'):
channel_type='release' channel_type='release'
elif channel_qualifier.startswith('beta'): elif channel_qualifier.startswith('beta'):
...@@ -519,7 +518,8 @@ def construct(self): ...@@ -519,7 +518,8 @@ def construct(self):
"slplugin.exe") "slplugin.exe")
# Get shared libs from the shared libs staging directory # Get shared libs from the shared libs staging directory
with self.prefix(src=os.path.join(os.pardir, 'sharedlibs', self.args['configuration'])): with self.prefix(src=os.path.join(self.args['build'], os.pardir,
'sharedlibs', self.args['configuration'])):
# Get llcommon and deps. If missing assume static linkage and continue. # Get llcommon and deps. If missing assume static linkage and continue.
try: try:
...@@ -612,17 +612,18 @@ def construct(self): ...@@ -612,17 +612,18 @@ def construct(self):
# Media plugins - CEF # Media plugins - CEF
with self.prefix(dst="llplugin"): with self.prefix(dst="llplugin"):
with self.prefix(src='../media_plugins/cef/%s' % self.args['configuration']): with self.prefix(src=os.path.join(self.args['build'], os.pardir, 'media_plugins')):
self.path("media_plugin_cef.dll") with self.prefix(src=os.path.join('cef', self.args['configuration'])):
self.path("media_plugin_cef.dll")
# Media plugins - LibVLC # Media plugins - LibVLC
with self.prefix(src='../media_plugins/libvlc/%s' % self.args['configuration']): with self.prefix(src=os.path.join('libvlc', self.args['configuration'])):
self.path("media_plugin_libvlc.dll") self.path("media_plugin_libvlc.dll")
# Media plugins - Example (useful for debugging - not shipped with release viewer) # Media plugins - Example (useful for debugging - not shipped with release viewer)
if self.channel_type() != 'release': if self.channel_type() != 'release':
with self.prefix(src='../media_plugins/example/%s' % self.args['configuration']): with self.prefix(src=os.path.join('example', self.args['configuration'])):
self.path("media_plugin_example.dll") self.path("media_plugin_example.dll")
# CEF runtime files - debug # CEF runtime files - debug
# CEF runtime files - not debug (release, relwithdebinfo etc.) # CEF runtime files - not debug (release, relwithdebinfo etc.)
...@@ -640,7 +641,8 @@ def construct(self): ...@@ -640,7 +641,8 @@ def construct(self):
self.path("widevinecdmadapter.dll") self.path("widevinecdmadapter.dll")
# MSVC DLLs needed for CEF and have to be in same directory as plugin # MSVC DLLs needed for CEF and have to be in same directory as plugin
with self.prefix(src=os.path.join(os.pardir, 'sharedlibs', 'Release')): with self.prefix(src=os.path.join(self.args['build'], os.pardir,
'sharedlibs', 'Release')):
self.path("msvcp120.dll") self.path("msvcp120.dll")
self.path("msvcr120.dll") self.path("msvcr120.dll")
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment