Skip to content
Snippets Groups Projects
Commit 11eac588 authored by Nathan Wilcox's avatar Nathan Wilcox
Browse files

DEV-44838 - Fix another bug introduced by passing "executable" in...

DEV-44838 - Fix another bug introduced by passing "executable" in WindowsSetup.run();  find_in_path() does not handle absolute paths, but name is guaranteed to be an absolute path.

This explains the bogus message in the log of the form "process $foo exited with nonzero status; process $foo is not found", described here:
https://jira.lindenlab.com/jira/browse/DEV-44838?focusedCommentId=328441&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_328441
parent f37f8066
No related branches found
No related tags found
No related merge requests found
...@@ -595,10 +595,7 @@ def run(self, command, name=None, retry_on=None, retries=1): ...@@ -595,10 +595,7 @@ def run(self, command, name=None, retry_on=None, retries=1):
ret = subprocess.call(command, executable=name) ret = subprocess.call(command, executable=name)
print "got ret", ret, "from", command print "got ret", ret, "from", command
if ret: if ret:
if name is None: if not name:
name = command.split(None, 1)[0]
path = self.find_in_path(name)
if not path:
error = 'was not found' error = 'was not found'
else: else:
error = 'exited with status %d' % ret error = 'exited with status %d' % ret
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment