Skip to content
Snippets Groups Projects
Commit 2029bf92 authored by Mike Antipov's avatar Mike Antipov
Browse files

Work on major bug EXT-3976 (Voice chat speaking indicators should only display...

Work on major bug EXT-3976 (Voice chat speaking indicators should only display when users are in the same voice channel)
-- improvements: added more comment for LLOutputMonitorCtrl::switchIndicator

--HG--
branch : product-engine
parent 44e1f34f
No related branches found
No related tags found
No related merge requests found
...@@ -279,14 +279,20 @@ void LLOutputMonitorCtrl::onChange() ...@@ -279,14 +279,20 @@ void LLOutputMonitorCtrl::onChange()
// virtual // virtual
void LLOutputMonitorCtrl::switchIndicator(bool switch_on) void LLOutputMonitorCtrl::switchIndicator(bool switch_on)
{ {
// ensure indicator is visible in case it is not in visible chain
// to be called when parent became visible next time to notify parent that visibility is changed.
setVisible(TRUE); setVisible(TRUE);
// if parent is in visible chain apply switch_on state and notify it immediately
if (getParent() && getParent()->isInVisibleChain()) if (getParent() && getParent()->isInVisibleChain())
{ {
LL_DEBUGS("SpeakingIndicator") << "Indicator is in visible chain, notifying parent: " << mSpeakerId << LL_ENDL; LL_DEBUGS("SpeakingIndicator") << "Indicator is in visible chain, notifying parent: " << mSpeakerId << LL_ENDL;
setVisible((BOOL)switch_on); setVisible((BOOL)switch_on);
notifyParentVisibilityChanged(); notifyParentVisibilityChanged();
} }
// otherwise remember necessary state and mark itself as dirty.
// State will be applied i next draw when parents chain became visible.
else else
{ {
LL_DEBUGS("SpeakingIndicator") << "Indicator is not in visible chain, parent won't be notified: " << mSpeakerId << LL_ENDL; LL_DEBUGS("SpeakingIndicator") << "Indicator is not in visible chain, parent won't be notified: " << mSpeakerId << LL_ENDL;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment