Skip to content
Snippets Groups Projects
Commit 317698ff authored by Andrey Kleshchev's avatar Andrey Kleshchev
Browse files

SL-16404 Crash in assetRequestCoro

Access violation at writing received data to vfs file. Most crashes indicate network issues, so adding additional response validation.
parent 98b416ff
No related branches found
No related tags found
No related merge requests found
...@@ -570,6 +570,18 @@ void LLViewerAssetStorage::assetRequestCoro( ...@@ -570,6 +570,18 @@ void LLViewerAssetStorage::assetRequestCoro(
result_code = LL_ERR_ASSET_REQUEST_FAILED; result_code = LL_ERR_ASSET_REQUEST_FAILED;
ext_status = LLExtStat::NONE; ext_status = LLExtStat::NONE;
} }
else if (!result.has(LLCoreHttpUtil::HttpCoroutineAdapter::HTTP_RESULTS_RAW))
{
LL_DEBUGS("ViewerAsset") << "request failed, no data returned!" << LL_ENDL;
result_code = LL_ERR_ASSET_REQUEST_FAILED;
ext_status = LLExtStat::NONE;
}
else if (!result[LLCoreHttpUtil::HttpCoroutineAdapter::HTTP_RESULTS_RAW].isBinary())
{
LL_DEBUGS("ViewerAsset") << "request failed, invalid data format!" << LL_ENDL;
result_code = LL_ERR_ASSET_REQUEST_FAILED;
ext_status = LLExtStat::NONE;
}
else else
{ {
LL_DEBUGS("ViewerAsset") << "request succeeded, url " << url << LL_ENDL; LL_DEBUGS("ViewerAsset") << "request succeeded, url " << url << LL_ENDL;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment