Cleanup up repeated calls to endInstances

indra/llcommon/lleventtimer.cpp

@@ -58,7 +58,7 @@ LLEventTimer::~LLEventTimer()
 void LLEventTimer::updateClass() 
 {
 	std::list<LLEventTimer*> completed_timers;
-	for (instance_iter iter = beginInstances(); iter != endInstances(); ) 
+	for (instance_iter iter = beginInstances(), end = endInstances(); iter != end; )
 	{
 		LLEventTimer& timer = *iter++;
 		F32 et = timer.mEventTimer.getElapsedTimeF32();
@@ -73,11 +73,9 @@ void LLEventTimer::updateClass()
 
 	if ( completed_timers.size() > 0 )
 	{
-		for (std::list<LLEventTimer*>::iterator completed_iter = completed_timers.begin(); 
-			 completed_iter != completed_timers.end(); 
-			 completed_iter++ ) 
+		for (LLEventTimer* completed_timer : completed_timers) 
 		{
-			delete *completed_iter;
+			delete completed_timer;
 		}
 	}
 }

indra/llrender/llgl.cpp

@@ -2390,7 +2390,7 @@ void LLGLNamePool::release(GLuint name)
 //static
 void LLGLNamePool::upkeepPools()
 {
-	for (tracker_t::instance_iter iter = beginInstances(); iter != endInstances(); ++iter)
+	for (tracker_t::instance_iter iter = beginInstances(), end = endInstances(); iter != end; ++iter)
 	{
 		LLGLNamePool & pool = *iter;
 		pool.upkeep();
@@ -2400,7 +2400,7 @@ void LLGLNamePool::upkeepPools()
 //static
 void LLGLNamePool::cleanupPools()
 {
-	for (tracker_t::instance_iter iter = beginInstances(); iter != endInstances(); ++iter)
+	for (tracker_t::instance_iter iter = beginInstances(), end = endInstances(); iter != end; ++iter)
 	{
 		LLGLNamePool & pool = *iter;
 		pool.cleanup();

indra/llui/llconsole.cpp

@@ -371,7 +371,7 @@ LLConsole::Paragraph::Paragraph (LLWString str, const LLColor4 &color, F32 add_t
 // static
 void LLConsole::updateClass()
 {	
-	for (instance_iter it = beginInstances(); it != endInstances(); ++it)
+	for (instance_iter it = beginInstances(), it_end = endInstances(); it != it_end; ++it)
 	{
 		it->update();
 	} 

indra/llui/lllayoutstack.cpp

@@ -636,7 +636,7 @@ void LLLayoutStack::createResizeBar(LLLayoutPanel* panelp)
 //static 
 void LLLayoutStack::updateClass()
 {
-	for (instance_iter it = beginInstances(); it != endInstances(); ++it)
+	for (instance_iter it = beginInstances(), end = endInstances(); it != end; ++it)
 	{
 		it->updateLayout();
 		it->mAnimatedThisFrame = false;

indra/newview/lltoast.cpp

@@ -612,8 +612,9 @@ S32	LLToast::notifyParent(const LLSD& info)
 //static
 void LLToast::updateClass()
 {
-	for (LLInstanceTracker<LLToast>::instance_iter iter = LLInstanceTracker<LLToast>::beginInstances(); 
-			iter != LLInstanceTracker<LLToast>::endInstances(); ) 
+	for (LLInstanceTracker<LLToast>::instance_iter iter = LLInstanceTracker<LLToast>::beginInstances(),
+		end = LLInstanceTracker<LLToast>::endInstances();
+			iter != end; )
 	{
 		LLToast& toast = *iter++;