Skip to content
Snippets Groups Projects
Commit 6f2009f3 authored by Kitty Barnett's avatar Kitty Barnett
Browse files

[FIXED] hasBehaviourExcept() with an empty option returns false even though a...

[FIXED] hasBehaviourExcept() with an empty option returns false even though a RLV_OPTION_MODIFIER active restriction exists
  -> RlvCommand::markRefCounted() is called from RlvBehaviourGenericProcessor<RLV_OPTION_MODIFIER> as expected
  -> However, the RlvCommand reference we pass throughout the entire command processing line is a reference to the originally parsed command and not a reference to the copy that was stored in the RlvObject's command list
  -> The fact that we're mutating a constant is excusable in this case since only the command processor will know whether an option command should end up getting reference counted
  -> This bug only applies to hasBehaviourExcept() since the behaviour reference counter was still incremented/decremented successfully and hasBehaviourExcept() does a deep check on the individual commands instead
  -> Fixes FIRE-24215
parent 68a0bdb0
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment