[FIXED] hasBehaviourExcept() with an empty option returns false even though a...
[FIXED] hasBehaviourExcept() with an empty option returns false even though a RLV_OPTION_MODIFIER active restriction exists -> RlvCommand::markRefCounted() is called from RlvBehaviourGenericProcessor<RLV_OPTION_MODIFIER> as expected -> However, the RlvCommand reference we pass throughout the entire command processing line is a reference to the originally parsed command and not a reference to the copy that was stored in the RlvObject's command list -> The fact that we're mutating a constant is excusable in this case since only the command processor will know whether an option command should end up getting reference counted -> This bug only applies to hasBehaviourExcept() since the behaviour reference counter was still incremented/decremented successfully and hasBehaviourExcept() does a deep check on the individual commands instead -> Fixes FIRE-24215
Showing
- indra/newview/rlvhandler.cpp 34 additions, 29 deletionsindra/newview/rlvhandler.cpp
- indra/newview/rlvhandler.h 3 additions, 3 deletionsindra/newview/rlvhandler.h
- indra/newview/rlvhelper.cpp 8 additions, 6 deletionsindra/newview/rlvhelper.cpp
- indra/newview/rlvhelper.h 2 additions, 2 deletionsindra/newview/rlvhelper.h
Loading
Please register or sign in to comment