-
- Downloads
"README.md" did not exist on "e58d50e509d060320174c80af647da6ff9a3839f"
MAINT-5011: Try to enrich catch (...) logging throughout viewer.
Turns out we have a surprising number of catch (...) clauses in the viewer code base. If all we currently do is LL_ERRS() << "unknown exception" << LL_ENDL; then call CRASH_ON_UNHANDLED_EXCEPTION() instead. If what we do is LL_WARNS() << "unknown exception" << LL_ENDL; then call LOG_UNHANDLED_EXCEPTION() instead. Since many places need LOG_UNHANDLED_EXCEPTION() and nobody catches LLContinueError yet, eliminate LLContinueError& parameter from LOG_UNHANDLED_EXCEPTION(). This permits us to use the same log message as CRASH_ON_UNHANDLED_EXCEPTION(), just with a different severity level. Where a catch (...) clause actually provides contextual information, or makes an error string, add boost::current_exception_diagnostic_information() to try to figure out actual exception class and message.
Showing
- indra/llcommon/llexception.cpp 18 additions, 11 deletionsindra/llcommon/llexception.cpp
- indra/llcommon/llexception.h 5 additions, 4 deletionsindra/llcommon/llexception.h
- indra/llkdu/llimagej2ckdu.cpp 9 additions, 4 deletionsindra/llkdu/llimagej2ckdu.cpp
- indra/llmessage/llavatarnamecache.cpp 2 additions, 1 deletionindra/llmessage/llavatarnamecache.cpp
- indra/llmessage/llcoproceduremanager.cpp 3 additions, 1 deletionindra/llmessage/llcoproceduremanager.cpp
- indra/newview/llaccountingcostmanager.cpp 2 additions, 1 deletionindra/newview/llaccountingcostmanager.cpp
- indra/newview/llappcorehttp.cpp 2 additions, 0 deletionsindra/newview/llappcorehttp.cpp
- indra/newview/llsecapi.cpp 1 addition, 0 deletionsindra/newview/llsecapi.cpp
- indra/newview/llsechandler_basic.cpp 7 additions, 3 deletionsindra/newview/llsechandler_basic.cpp
- indra/viewer_components/login/lllogin.cpp 2 additions, 1 deletionindra/viewer_components/login/lllogin.cpp
Loading
Please register or sign in to comment