Skip to content
Snippets Groups Projects
Commit b2d76953 authored by Monty Brandenberg's avatar Monty Brandenberg
Browse files

Code review updates. All comments so far.

parent d191585a
No related branches found
No related tags found
No related merge requests found
...@@ -155,11 +155,9 @@ class LL_COMMON_API LLDeadmanTimer ...@@ -155,11 +155,9 @@ class LL_COMMON_API LLDeadmanTimer
/// ///
void ringBell(time_type now, unsigned int count); void ringBell(time_type now, unsigned int count);
/// Checks on the status of the timer Declare that something interesting happened. This has two /// Checks the status of the timer. If the timer has expired,
/// effects on an unexpired-timer. 1) The expiration time /// also returns various timer-related stats. Unlike ringBell(),
/// is extended for 'horizon' seconds after the 'now' value. /// does not extend the horizon, it only checks for expiration.
/// 2) An internal counter associated with the event is incremented.
/// This count is returned via the @see isExpired() method.
/// ///
/// @param now Current time as returned by @see /// @param now Current time as returned by @see
/// LLTimer::getCurrentClockCount(). If zero, /// LLTimer::getCurrentClockCount(). If zero,
...@@ -192,7 +190,7 @@ class LL_COMMON_API LLDeadmanTimer ...@@ -192,7 +190,7 @@ class LL_COMMON_API LLDeadmanTimer
bool isExpired(time_type now, F64 & started, F64 & stopped, U64 & count, bool isExpired(time_type now, F64 & started, F64 & stopped, U64 & count,
U64 & user_cpu, U64 & sys_cpu); U64 & user_cpu, U64 & sys_cpu);
/// Identical to the six-arugment form except is does without the /// Identical to the six-arugment form except it does without the
/// CPU time return if the caller isn't interested in it. /// CPU time return if the caller isn't interested in it.
bool isExpired(time_type now, F64 & started, F64 & stopped, U64 & count); bool isExpired(time_type now, F64 & started, F64 & stopped, U64 & count);
......
...@@ -296,7 +296,7 @@ LLCurl::Easy* LLCurl::Easy::getEasy() ...@@ -296,7 +296,7 @@ LLCurl::Easy* LLCurl::Easy::getEasy()
// Enable a brief cache period for now. This was zero for the longest time // Enable a brief cache period for now. This was zero for the longest time
// which caused some routers grief and generated unneeded traffic. For the // which caused some routers grief and generated unneeded traffic. For the
// threded resolver, we're using system resolution libraries and non-zero values // threaded resolver, we're using system resolution libraries and non-zero values
// are preferred. The c-ares resolver is another matter and it might not // are preferred. The c-ares resolver is another matter and it might not
// track server changes as well. // track server changes as well.
CURLcode result = curl_easy_setopt(easy->mCurlEasyHandle, CURLOPT_DNS_CACHE_TIMEOUT, 15); CURLcode result = curl_easy_setopt(easy->mCurlEasyHandle, CURLOPT_DNS_CACHE_TIMEOUT, 15);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment