Fixed bug EXT-6399 (System locale is the same for all languages).
Problem: * English locale was set for all languages. * Specifying a correct locale didn't affect anything, including date/time formatting. My investigation has shown that LLStringUtil was instantiated twice: in the main binary and in libllcommon.so. Because LLStringUtil::setLocale() was called from newview and getLocale() was called from llcommon, they effectively used *different* instances of LLStringUtil::sLocale. Hence getLocale() always returned empty string. This seems to be caused by get/setLocale() methods not being dllexported. The fix instantiates get/setLocale() and sLocale in llcommon and exposes them to use from newview (i.e. prevents multiple instantiation). Besides, I specified correct locale names for all languages and platforms. Reviewed by Leyla: https://codereview.productengine.com/secondlife/r/104/ --HG-- branch : product-engine
Showing
- indra/llcommon/llstring.cpp 14 additions, 0 deletionsindra/llcommon/llstring.cpp
- indra/llcommon/llstring.h 2 additions, 2 deletionsindra/llcommon/llstring.h
- indra/newview/skins/default/xui/da/language_settings.xml 3 additions, 3 deletionsindra/newview/skins/default/xui/da/language_settings.xml
- indra/newview/skins/default/xui/de/language_settings.xml 3 additions, 3 deletionsindra/newview/skins/default/xui/de/language_settings.xml
- indra/newview/skins/default/xui/es/language_settings.xml 3 additions, 3 deletionsindra/newview/skins/default/xui/es/language_settings.xml
- indra/newview/skins/default/xui/fr/language_settings.xml 3 additions, 3 deletionsindra/newview/skins/default/xui/fr/language_settings.xml
- indra/newview/skins/default/xui/it/language_settings.xml 3 additions, 3 deletionsindra/newview/skins/default/xui/it/language_settings.xml
- indra/newview/skins/default/xui/ja/language_settings.xml 3 additions, 3 deletionsindra/newview/skins/default/xui/ja/language_settings.xml
- indra/newview/skins/default/xui/nl/language_settings.xml 3 additions, 3 deletionsindra/newview/skins/default/xui/nl/language_settings.xml
- indra/newview/skins/default/xui/pl/language_settings.xml 3 additions, 3 deletionsindra/newview/skins/default/xui/pl/language_settings.xml
- indra/newview/skins/default/xui/pt/language_settings.xml 3 additions, 3 deletionsindra/newview/skins/default/xui/pt/language_settings.xml
Loading
Please register or sign in to comment