-
- Downloads
EXT-8010 ADDITIONAL FIX Fixed problems with avatar links underlining.
There were two problems: 1. Underlining broke when avatar's first and second name were on different lines. 2. There was no underline on hover for avatar miniinspector links in plaintext IM. - First problem was caused by calling LLOnHoverChangeableTextSegment::draw() for the same segment twice- for first and second name that were on different lines, while handleHover() was called only once. So handleHover() was called -> text was underlined -> first part of segment was drawn underlined -> its draw set style back to normal -> second part of segment was drawn without underlining. Fixed this by setting style back to normal only when drawing the last part of the segment. - Second problem was caused by unusual way of appending link to text in chat history. Changed it so that LLTextBase::appendText() now receives link not inside style params, but directly. Also added "/inspect" ending to check in LLUrlEntryAgent::underlineOnHoverOnly(). Reviewed by Richard Nelson at https://codereview.productengine.com/secondlife/r/833/ --HG-- branch : product-engine
Showing
- indra/llui/lltextbase.cpp 4 additions, 1 deletionindra/llui/lltextbase.cpp
- indra/llui/llurlentry.cpp 1 addition, 1 deletionindra/llui/llurlentry.cpp
- indra/newview/llchathistory.cpp 3 additions, 2 deletionsindra/newview/llchathistory.cpp
- indra/newview/llstylemap.cpp 2 additions, 10 deletionsindra/newview/llstylemap.cpp
Loading
Please register or sign in to comment