Skip to content
Snippets Groups Projects
Commit d6ddec8e authored by Rye Mutt's avatar Rye Mutt :bread:
Browse files

Fix various cmake dependency warnings

parent 8b179e31
No related branches found
No related tags found
No related merge requests found
...@@ -57,14 +57,6 @@ target_link_libraries(media_plugin_example ...@@ -57,14 +57,6 @@ target_link_libraries(media_plugin_example
${PLUGIN_API_WINDOWS_LIBRARIES} ${PLUGIN_API_WINDOWS_LIBRARIES}
) )
add_dependencies(media_plugin_example
${LLPLUGIN_LIBRARIES}
${MEDIA_PLUGIN_BASE_LIBRARIES}
# Using ${LLCOMMON_LIBRARIES} here drags in a whole bunch of Boost stuff
# that only produces CMake warnings about nonexistent dependencies.
llcommon
)
if (WINDOWS) if (WINDOWS)
set_target_properties( set_target_properties(
media_plugin_example media_plugin_example
......
...@@ -65,11 +65,3 @@ target_link_libraries(media_plugin_gstreamer010 ...@@ -65,11 +65,3 @@ target_link_libraries(media_plugin_gstreamer010
${PLUGIN_API_WINDOWS_LIBRARIES} ${PLUGIN_API_WINDOWS_LIBRARIES}
${GSTREAMER010_LIBRARIES} ${GSTREAMER010_LIBRARIES}
) )
add_dependencies(media_plugin_gstreamer010
${LLPLUGIN_LIBRARIES}
${MEDIA_PLUGIN_BASE_LIBRARIES}
${LLCOMMON_LIBRARIES}
)
...@@ -58,22 +58,6 @@ target_link_libraries(media_plugin_libvlc ...@@ -58,22 +58,6 @@ target_link_libraries(media_plugin_libvlc
${PLUGIN_API_WINDOWS_LIBRARIES} ${PLUGIN_API_WINDOWS_LIBRARIES}
) )
add_dependencies(media_plugin_libvlc
${LLPLUGIN_LIBRARIES}
${MEDIA_PLUGIN_BASE_LIBRARIES}
##${LLCOMMON_LIBRARIES}
# Just say 'llcommon' here. LLCOMMON_LIBRARIES is specified for use in
# target_link_libraries: it includes several Boost libraries, which are
# absolutely NOT dependencies in the sense intended here. Those Boost
# library macros, in turn, specify 'debug' and 'optimized' and a different
# library name for each, producing several wordy errors:
# Policy CMP0046 is not set: Error on non-existent dependency in
# add_dependencies.
# Really, the only dependency we should mention from LLCOMMON_LIBRARIES is
# llcommon itself.
llcommon
)
if (WINDOWS) if (WINDOWS)
set_target_properties( set_target_properties(
media_plugin_libvlc media_plugin_libvlc
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment