BUGFIX: Correcting a crash issue that was caused by the rebake navmesh...

BUGFIX: Correcting a crash issue that was caused by the rebake navmesh callback handler unexpectedly changing the navmesh state.

indra/cmake/LLPhysicsExtensions.cmake

@@ -22,7 +22,7 @@ find_library(LL_PHYSICS_RELWITHDEBINFO_LIB ${LLPHYSICS_EXTENSIONS_LIB_NAME} PATH
 set(LLPHYSICS_LIBRARIES
 
     debug     ${LL_PHYSICS_DEBUG_LIB}
-    optimized ${LL_PHYSICS_RELEASE_LIB}
+    optimized ${LL_PHYSICS_RELWITHDEBINFO_LIB}
 )
 
 if (LINUX)

indra/newview/llpanelpathfindingrebakenavmesh.cpp

@@ -159,6 +159,11 @@ void LLPanelPathfindingRebakeNavmesh::setMode(ERebakeNavMeshMode pRebakeNavMeshM
 	mRebakeNavMeshMode = pRebakeNavMeshMode;
 }
 
+LLPanelPathfindingRebakeNavmesh::ERebakeNavMeshMode LLPanelPathfindingRebakeNavmesh::getMode() const
+{
+	return mRebakeNavMeshMode;
+}
+
 void LLPanelPathfindingRebakeNavmesh::onNavMeshRebakeClick()
 {
 	setMode(kRebakeNavMesh_RequestSent);
@@ -172,16 +177,14 @@ void LLPanelPathfindingRebakeNavmesh::handleAgentState(BOOL pCanRebakeRegion)
 
 void LLPanelPathfindingRebakeNavmesh::handleRebakeNavMeshResponse(bool pResponseStatus)
 {
-	setMode(pResponseStatus ? kRebakeNavMesh_InProgress : kRebakeNavMesh_Default);
-	if (!pResponseStatus)
+	if (getMode() == kRebakeNavMesh_RequestSent)
 	{
-		LLNotificationsUtil::add("PathfindingCannotRebakeNavmesh");
+		setMode(pResponseStatus ? kRebakeNavMesh_InProgress : kRebakeNavMesh_Default);
 	}
 
-	LLViewerRegion *currentRegion = gAgent.getRegion();
-	if (currentRegion != NULL)
+	if (!pResponseStatus)
 	{
-		LLPathfindingManager::getInstance()->requestGetNavMeshForRegion(currentRegion, true);
+		LLNotificationsUtil::add("PathfindingCannotRebakeNavmesh");
 	}
 }
 

indra/newview/llpanelpathfindingrebakenavmesh.h

@@ -66,7 +66,8 @@ class LLPanelPathfindingRebakeNavmesh : public LLPanel
 
 	static LLPanelPathfindingRebakeNavmesh* getPanel();
 
-	void setMode(ERebakeNavMeshMode pRebakeNavMeshMode);
+	void               setMode(ERebakeNavMeshMode pRebakeNavMeshMode);
+	ERebakeNavMeshMode getMode() const;
 	
 	void onNavMeshRebakeClick();